Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild package-lock.json to fix npm audit errors #379

Merged
merged 1 commit into from Mar 20, 2020
Merged

Conversation

@bsclifton
Copy link
Member

bsclifton commented Mar 20, 2020

Fixes brave/brave-browser#8722

NOTE: uses optional-dev-dependency to make the test runners "optional". The clean package-lock.json rebuild did not solve the issues there

@bsclifton bsclifton requested a review from diracdeltas Mar 20, 2020
@bsclifton bsclifton self-assigned this Mar 20, 2020
package.json Outdated Show resolved Hide resolved
@bsclifton bsclifton force-pushed the bsc-fix-npm branch from c379694 to 32bd844 Mar 20, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

bsclifton added a commit that referenced this pull request Mar 20, 2020
@bsclifton bsclifton merged commit c96a1e1 into master Mar 20, 2020
3 checks passed
3 checks passed
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bsclifton bsclifton deleted the bsc-fix-npm branch Mar 20, 2020
bsclifton added a commit to brave/brave-core that referenced this pull request Mar 20, 2020
Fixes brave/brave-browser#8722

Updates `sync` in `DEPS` to have updated hash from brave/sync#379
@bsclifton bsclifton mentioned this pull request Mar 20, 2020
6 of 32 tasks complete
bsclifton added a commit to brave/brave-core that referenced this pull request Mar 20, 2020
Fixes brave/brave-browser#8722

Updates `sync` in `DEPS` to have updated hash from brave/sync#379
bsclifton added a commit that referenced this pull request Mar 31, 2020
Manual cherry-pick of #379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.