Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual cherry-pick of https://github.com/brave/sync/pull/379 #384

Merged
merged 1 commit into from Mar 31, 2020
Merged

Manual cherry-pick of https://github.com/brave/sync/pull/379 #384

merged 1 commit into from Mar 31, 2020

Conversation

@bsclifton
Copy link
Member

bsclifton commented Mar 20, 2020

  • removed package-lock.json
  • made tape-run optional
@bsclifton
Manual cherry-pick of #379
Loading status checks…
2f7f16d
@bsclifton bsclifton requested review from diracdeltas and AlexeyBarabash Mar 20, 2020
@bsclifton bsclifton self-assigned this Mar 20, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information
@AlexeyBarabash
AlexeyBarabash approved these changes Mar 20, 2020
View changes
Copy link
Contributor

AlexeyBarabash left a comment

looks good to me
@bsclifton bsclifton merged commit ab61435 into master-pre-dup-dev-id Mar 31, 2020
3 checks passed
3 checks passed
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bsclifton bsclifton deleted the pre-dev-id-fix-npm branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyBarabash AlexeyBarabash

@diracdeltas diracdeltas

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bsclifton @AlexeyBarabash
You can’t perform that action at this time.