Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd SyncRecord.siteSetting.fields #39
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedJan 18, 2017
•
edited
Currently you can't encode a siteSetting with just a single setting . For example, a SyncRecord with
siteSetting: {shieldsUp: true}encoded and decoded returns additionally all the siteSetting fields's defaults. This is because proto3 doesn't distinguish between fields set to default values and unset fields.This PR adds the
SyncRecord.siteSetting.fieldswith which we'll specify the changed fields. This is similar to google.protobuf.Fieldmask.recordUtil.syncRecordAsJS() will take
fieldsinto account when converting records back to the browser client format.