Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start sync client #5

Merged
merged 1 commit into from Dec 8, 2016
Merged

start sync client #5

merged 1 commit into from Dec 8, 2016

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Dec 8, 2016

this initializes the sync client and authenticates it using the local test server.

auditors: @ayumi

test plan:

  1. npm run buildtest
  2. in a separate terminal, run python -m SimpleHTTPServer
  3. go to localhost:8000/client.html in a browser, open the console, it should say 'successfully authenticated'
this initializes the sync client and authenticates it using the local test server.

auditors: @ayumi

test plan:
1. npm run buildtest
2. in a separate terminal, run `python -m SimpleHTTPServer`
3. go to localhost:8000/client.html in a browser, open the console, it should say 'successfully authenticated'
@diracdeltas diracdeltas requested a review from ayumi Dec 8, 2016
@ayumi
ayumi approved these changes Dec 8, 2016
Copy link
Contributor

ayumi left a comment

lgtm

@diracdeltas diracdeltas merged commit 778608d into master Dec 8, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@diracdeltas diracdeltas deleted the feature/client-init branch Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.