Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bookmark.index; add prev and next objectIds #56

Merged
merged 2 commits into from Feb 14, 2017

Conversation

@ayumi
Copy link
Contributor

ayumi commented Feb 14, 2017

  • Bookmark.index isn't needed because we increased timestamp resolution to ms in #54 so as long as we upload in the correct order they will download in the same order.
  • Supports #55

Test plan: make sure tests pass

ayumi added 2 commits Feb 14, 2017
To support #55
@ayumi ayumi requested a review from diracdeltas Feb 14, 2017
@diracdeltas diracdeltas merged commit 51453d0 into staging Feb 14, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ayumi ayumi deleted the feature/bookmark-order-fields branch Feb 14, 2017
ayumi added a commit to brave/browser-laptop that referenced this pull request Feb 14, 2017
Related: brave/sync#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.