Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Docker support #63
Conversation
|
i'm in favor of this, though not terribly familiar with docker |
farfeduc
commented
Jul 25, 2017
•
|
I have some experience with Docker (even-though seeing my github profile might not reflect this) and this docker image cannot be much improved upon. I would just add some of the environment variables available to configure the server. As for the CI, the Docker hub automatic build upon push should be plenty. As for the readme, I would add to the PR, at the bottom of the current file something like : (with the proper comments for the environment variables) SelfHostingDockerRun the sync server with :
Replace the following environment variable values with your AWS info (self-explanatory) :
Other variables also available :
This image is built from this Dockerfile on the Docker hub |
jdoubleu commentedMar 9, 2017
Instead of creating a new feature request I decided to implement it my own.
What does this PR?
Adding docker support: The sync server is run from inside a docker container having all dependencies met so it's easy to run a Brave sync server. The only thing you need is docker installed.
Things to be done before merging
How about publishing this image on the official Docker Repo (Docker Hub) as an official image?
What do you think about it?