Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFETCH_SYNC_RECORDS can limit response to 1000 records #69
+83
−54
Conversation
| @@ -80,20 +76,22 @@ const maybeSetDeviceId = (requester) => { | |||
| * @param {RequestUtil} requester | |||
| */ | |||
| const startSync = (requester) => { | |||
| ipc.on(messages.FETCH_SYNC_RECORDS, (e, categoryNames, startAt) => { | |||
| ipc.on(messages.FETCH_SYNC_RECORDS, (e, categoryNames, startAt, limitResponse) => { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedApr 5, 2017
•
edited
Fix #68
browser/lib API changes:
limitResponse(boolean). when set to true, limits response to 1000 (previously unbounded)lastRecordTimestamp(number), the timestamp in milliseconds of the last record in a response batch. Useful as a cursor for traversing batches of 1000.Test plan:
yarn distinto browser-laptopyarn test -- --grep='"^Syncing"')