Server returns AWS region and S3 bucket #7

ayumi · 2016-12-15T05:53:41Z

Server returns s3 bucket and aws region.
requestUtil uses the bucket when instantiating Aws.S3
client saves region but doesn't use it (yet).

diracdeltas · 2016-12-15T06:03:45Z

client/requestUtil.js

 */
-module.exports.parseAWSResponse = (serializer, bytes, region) => {
+module.exports.parseAWSResponse = (serializer, bytes) => {


diracdeltas · 2016-12-15T06:08:31Z

plz run npm run build to rebuild the client bundle (we should eventually make a pre-commit hook for this)


        Server returns AWS region and S3 bucket

ayumi requested a review from diracdeltas Dec 15, 2016

diracdeltas reviewed Dec 15, 2016

View changes

client/requestUtil.js

*/

module.exports.parseAWSResponse = (serializer, bytes, region) => {

module.exports.parseAWSResponse = (serializer, bytes) => {

This comment has been minimized.

Sign in to view

Copy link

diracdeltas Dec 15, 2016
Member

👍

ayumi force-pushed the fix/s3-bucket-2 branch from d7f1de1 to cd23359 Dec 15, 2016

Server returns AWS region and S3 bucket

Loading status checks…

eaaf263

ayumi force-pushed the fix/s3-bucket-2 branch from cd23359 to eaaf263 Dec 15, 2016

ayumi merged commit 65f4310 into staging Dec 15, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

continuous-integration/travis-ci/push The Travis CI build passed
Details

ayumi deleted the fix/s3-bucket-2 branch Dec 15, 2016

brave / sync

Server returns AWS region and S3 bucket #7

Server returns AWS region and S3 bucket #7

ayumi commented Dec 15, 2016 •

edited

This comment has been minimized.

diracdeltas commented Dec 15, 2016

brave / sync

Join GitHub today

Server returns AWS region and S3 bucket #7

Server returns AWS region and S3 bucket #7

Conversation

ayumi commented Dec 15, 2016 • edited

This comment has been minimized.

diracdeltas Dec 15, 2016

diracdeltas commented Dec 15, 2016

ayumi commented Dec 15, 2016 •

edited