Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update master v1.1.0 #70

Merged
merged 11 commits into from Apr 6, 2017
Merged

update master v1.1.0 #70

merged 11 commits into from Apr 6, 2017

Conversation

@ayumi
Copy link
Contributor

ayumi commented Apr 6, 2017

No description provided.

diracdeltas added 5 commits Mar 15, 2017
@diracdeltas
Set CORS on app instead of Router
Loading status checks…
147f55b 
This restores the express CORS header needed on the credentials endpoint.

Also fixes credential error handling when 'error.message' is undefined.

Auditors: @ayumi
@diracdeltas
use cors generally
Loading status checks…
2c3ee42
@diracdeltas
Revert CORS changes, pin to older express version
Loading status checks…
8224343
@diracdeltas
Revert "Revert CORS changes, pin to older express version"
Loading status checks…
3e9241d 
This reverts commit 8224343.
@diracdeltas
use CORS on only the credentials POST endpoint
Loading status checks…
c131376 
The CORS errors I was having are gone now, so this reverts staging to be the same as master.

auditors: @ayumi
@ayumi

This comment has been minimized.

Sign in to view
Copy link
Contributor

ayumi commented on c131376 Apr 5, 2017

🎉
diracdeltas and others added 6 commits Apr 5, 2017
@diracdeltas
do not yarn upgrade on every build
c2af606
@diracdeltas
Add SYNC_SETUP_ERROR message
Loading status checks…
0096e03 
for when sync initialization fails.
fix #66
@diracdeltas
Merge pull request #67 from brave/fix/66
Loading status checks…
3de58c2 
Fix #66
@ayumi
RequestUtil.s3ObjectsToRecords(); FETCH_SYNC_RECORDS lastRecordTimestamp
Verified
This commit was signed with a verified signature.
ayumi ａｙｕｍｉ  ｙｕ
GPG key ID: FFC29CB6ED2EC961 Learn about signing commits
23315b9 
.list() returns raw S3 objects now
@ayumi
Add limitResponse option to FETCH_SYNC_RECORDS
Verified
This commit was signed with a verified signature.
ayumi ａｙｕｍｉ  ｙｕ
GPG key ID: FFC29CB6ED2EC961 Learn about signing commits
Loading status checks…
349592a
@ayumi
Merge pull request #69 from brave/feature/fetch-records-with-limit
Loading status checks…
88a35e8 
FETCH_SYNC_RECORDS can limit response to 1000 records
@ayumi ayumi merged commit 89c0af3 into master Apr 6, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ayumi @diracdeltas
You can’t perform that action at this time.