Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set client device ID, gitignore client bundle #8

Merged
merged 2 commits into from Dec 17, 2016
Merged

Set client device ID, gitignore client bundle #8

merged 2 commits into from Dec 17, 2016

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Dec 17, 2016

Auditors: @ayumi

test plan:
npm run client and navigate to http://localhost:8000/client.html. The page
should not show any 'ERROR' messages and should end with 'success'.
@diracdeltas
Set client device ID, gitignore client bundle
Loading status checks…
ac7a775 
Auditors: @ayumi
@diracdeltas diracdeltas requested a review from ayumi Dec 17, 2016
@ayumi
ayumi approved these changes Dec 17, 2016
View changes
Copy link
Contributor

ayumi left a comment

lctm
@diracdeltas
s/fork/branch
Loading status checks…
d082472
@diracdeltas diracdeltas merged commit f5155a9 into staging Dec 17, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@diracdeltas diracdeltas deleted the feature/device-id branch Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayumi ayumi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@diracdeltas @ayumi
You can’t perform that action at this time.