Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd hideInToolbar field to api.proto bookmarks #93
Conversation
|
i think this looks good tests are borked for unrelated reasons i think |
lib/api.proto
Outdated
| repeated string fields = 6; | ||
| bytes previousObjectId = 4; // unused | ||
| bytes nextObjectId = 5; // unused | ||
| repeated string fields = 6; // unused |
This comment has been minimized.
This comment has been minimized.
ayumi
Jun 2, 2017
Contributor
i think fields is used to show which fields were sent in a sync record
This comment has been minimized.
This comment has been minimized.
diracdeltas
Jun 2, 2017
Author
Member
hm i couldn't find anywhere it was used in browser-laptop but i'll remove the comment for now
needed for brave/browser-laptop#8024
|
@ayumi test unborked by upgrading from precise to trusty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
diracdeltas commentedJun 2, 2017
needed for brave/browser-laptop#8024