Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-sync with uBo master #7
Merged
+1,543
−809
Conversation
The blocking-stuff button icons have been brought closer to the power button. The go-somewhere button icons have been moved at the bottom. The hostname of the current site is now shown below the power button. The base domain is bolded. This re-ordering is for a few reasons: - The blocking-stuff button icons are now closer to the revert/persist/reload transient buttons which show up when modifying the blocking behavior of uBO. - The makes it easier to potentially bring in a very basic view where only the power button and the statistics are shown and all the button icons are hidden from view.
Specifically: - Log entries as received by client code - Prettier and more readable console output - Ability to only log entries matching a specific needle As per internal discussion at <https://github.com/uBlockOrigin/uAssets>; limited logging capabilities of json-prune originally raised by <https://github.com/gwarser>.
Related fedback: - gorhill@db9c321#commitcomment-38818960
The old "classic" popup panel will still be used when at least one of the following is true: - advanced setting `uiFlavor` is set to `classic`; or - the browser is Chromium 65 or older; or - the browser is Firefox 67 or older The default configuration of the new popup panel at installation time is to show the power button, statistics and the basic tool icons, i.e. access to dashboard, logger, pickers. For existing installations, the new popup panel will be configured by respecting the existing configuration of the classic one. The new popup panel is currently already in use on Firefox for Android, and the visual redesign was made according to suggestions and feedback from <https://github.com/brampitoyo> to be optimal for Firefox for Android. The new popup panel will allow closing the following pending issues: - uBlockOrigin/uBlock-issues#255 - uBlockOrigin/uBlock-issues#178
This comment has been minimized.
This comment has been minimized.
|
Additional height?
I think we had bug report about this too. |
This comment has been minimized.
This comment has been minimized.
|
I probably closed it back then as "by design". I just felt the new design does not look awkward with the unbound height. Hmm this makes me realize I forgot to remove that line. |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
After this change, I think it will be handy to have keyboard shortcut for the Dashboard :) |
Related feedback: - gorhill@9a6feb3#commitcomment-38852663
Related feedback: - uBlockOrigin/uBlock-issues#733 (comment)
Originally the idea was to hide from view the popup panel layout seemingly being recalculated by the browser at open time, causing visuals in the popup panel to slightly move around. Possibly no longer an issue now that the popup panel initialization code has been modified since then to use animation frames.
Related issue: - uBlockOrigin/uBlock-issues#1004 The fix is trivial enough that I feel confident to make it part of current RC cycle. There are many reports of block page at launch on Chromium. The fix is to let the platform pick it's natural suspend state rather than force it. Once advanced settings are read, the suspend state will for toggled only if `suspendTabsUntilReady` is either `yes` or `no`. This there should no longer be blocked page on Chromium at launch when using default settings. Related feedback: - https://www.reddit.com/r/uBlockOrigin/comments/gac2h8/
|
If you can review when you're free next @pes10k :) |
|
No privacy relevant changes upstream; lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanbr commentedMay 9, 2020
No description provided.