Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync with uBo master #7

Merged
merged 76 commits into from May 9, 2020
Merged

Re-sync with uBo master #7

merged 76 commits into from May 9, 2020
Commits on Apr 27, 2020
  1. Re-order sections in the new popup panel

    gorhill committed Apr 27, 2020
    The blocking-stuff button icons have been brought
    closer to the power button.
    
    The go-somewhere button icons have been moved at
    the bottom.
    
    The hostname of the current site is now shown below
    the power button. The base domain is bolded.
    
    This re-ordering is for a few reasons:
    
    - The blocking-stuff button icons are now closer
      to the revert/persist/reload transient buttons
      which show up when modifying the blocking
      behavior of uBO.
    
    - The makes it easier to potentially bring in a
      very basic view where only the power button and
      the statistics are shown and all the button
      icons are hidden from view.
  2. New revision for dev build

    gorhill committed Apr 27, 2020
Commits on Apr 28, 2020
  1. Improve logging capabilities of json-prune scriptlet

    gorhill committed Apr 28, 2020
    Specifically:
    
    - Log entries as received by client code
    - Prettier and more readable console output
    - Ability to only log entries matching a
      specific needle
    
    As per internal discussion at
    <https://github.com/uBlockOrigin/uAssets>; limited
    logging capabilities of json-prune originally raised
    by <https://github.com/gwarser>.
  2. Improve presentation of advanced settings page

    gorhill committed Apr 28, 2020
    Specifically:
    
    - Fix exception being thrown when createing an
      empty line
    
    - Syntax-color invalid setting names
    
    - Syntax-color non-default values
  3. Add `uBO:` prefix to logged output in some scriptlets

    gorhill committed Apr 28, 2020
    As per request.
  4. new revision for dev build

    gorhill committed Apr 28, 2020
  5. Minor code review

    gorhill committed Apr 28, 2020
Commits on Apr 29, 2020
  1. Fix own-rule text color

    gorhill committed Apr 29, 2020
  2. new revision for dev build

    gorhill committed Apr 29, 2020
Commits on Apr 30, 2020
  1. Make the new "fenix" popup panel the default one

    gorhill committed Apr 30, 2020
    The old "classic" popup panel will still be used
    when at least one of the following is true:
    
    - advanced setting `uiFlavor` is set to `classic`; or
    - the browser is Chromium 65 or older; or
    - the browser is Firefox 67 or older
    
    The default configuration of the new popup panel
    at installation time is to show the power button,
    statistics and the basic tool icons, i.e. access
    to dashboard, logger, pickers.
    
    For existing installations, the new popup panel
    will be configured by respecting the existing
    configuration of the classic one.
    
    The new popup panel is currently already in use
    on Firefox for Android, and the visual redesign
    was made according to suggestions and feedback
    from <https://github.com/brampitoyo> to be
    optimal for Firefox for Android.
    
    The new popup panel will allow closing the following
    pending issues:
    
    - uBlockOrigin/uBlock-issues#255
    - uBlockOrigin/uBlock-issues#178
  2. New revision for dev build

    gorhill committed Apr 30, 2020
Commits on May 1, 2020
  1. new revision for dev build

    gorhill committed May 1, 2020
  2. Allow hiding blocked count since install in popup panel

    gorhill committed May 1, 2020
    Also, more fine tuning of visuals.
    
    Two new advanced settings, to be left undocumented as
    "purposefully undocumented setting".
  3. New revision for dev build

    gorhill committed May 1, 2020
Commits on May 2, 2020
  1. New revision for dev build

    gorhill committed May 2, 2020
  2. Simplify HTML a bit

    gorhill committed May 2, 2020
Commits on May 3, 2020
  1. Maybe fix rare spurious viewport width test in popup panel

    gorhill committed May 3, 2020
    In rare instances -- though it definitely happens
    eventually -- the popup panel viewport width is seen as
    insufficiently wide enough and as a result the popup panel
    is toggled into vertical-layout mode.
    
    The added code uses animation frames to delay the
    code testing the viewport width. Hopefully this will
    work.
  2. Add tolerance to popup panel when checking viewport width

    gorhill committed May 3, 2020
    I meant to add this to last commit:
    - gorhill@a547188
  3. New revision for dev build

    gorhill committed May 3, 2020
Commits on May 4, 2020
  1. Fix power button not rendering on Firefox 68 ESR

    gorhill committed May 4, 2020
    Related feedback:
    - gorhill@1f91e52#commitcomment-38930600
    
    Looking through MDN documentation, I am unable to
    understand why this was broken on Firefox 68 ESR while
    this worked fine on Firefox 75.
  2. Re-design document-blocked page as per feedback

    gorhill committed May 4, 2020
    Related issue:
    - uBlockOrigin/uBlock-issues#1005
    
    There is probably more work to do regarding the
    shown URL -- it might be better to truncate it
    on small screen display since it can be quite
    long sometimes.
  3. Minor fine tuning of popup panel visual

    gorhill committed May 4, 2020
    Specifically:
    - Comply with Firefox iconography's size: multiple
      of 16px
    
    Related feedback:
    - uBlockOrigin/uBlock-issues#1005
  4. New revision for dev build

    gorhill committed May 4, 2020
  5. Override font size of select on desktop

    gorhill committed May 4, 2020
    Regression, related commit:
    - gorhill@c7d196d
Commits on May 5, 2020
  1. Avoid fractional pixel in viewport height

    gorhill committed May 5, 2020
    Fractional pixel could lead to minor scrollbar
    glitch -- reported internally.
Commits on May 6, 2020
  1. Improve heuristic to toggle panel to vertical layout

    gorhill committed May 6, 2020
    By using a larger tolerance.
    
    Also, ensure that the hover visuals are still
    being used in vertical layout mode on non-mobile
    devices.
  2. Shorten transition duration

    gorhill committed May 6, 2020
  3. Opacity transition probably not needed after all

    gorhill committed May 6, 2020
    Originally the idea was to hide from view the
    popup panel layout seemingly being recalculated
    by the browser at open time, causing visuals in
    the popup panel to slightly move around. Possibly
    no longer an issue now that the popup panel
    initialization code has been modified since then
    to use animation frames.
  4. Simplify max-width rule of popup panel

    gorhill committed May 6, 2020
    Maybe it will help avoid the spurious
    fall-into-vertical-layout issue. Maybe not.
Commits on May 7, 2020
  1. Let the platform pick the default suspend state at launch

    gorhill committed May 7, 2020
    Related issue:
    - uBlockOrigin/uBlock-issues#1004
    
    The fix is trivial enough that I feel confident to make
    it part of current RC cycle. There are many reports of
    block page at launch on Chromium.
    
    The fix is to let the platform pick it's natural suspend
    state rather than force it. Once advanced settings are
    read, the suspend state will for toggled only if
    `suspendTabsUntilReady` is either `yes` or `no`. This
    there should no longer be blocked page on Chromium at
    launch when using default settings.
    
    Related feedback:
    - https://www.reddit.com/r/uBlockOrigin/comments/gac2h8/
Commits on May 8, 2020
  1. Minor fine-tuning of visual of `select` elements

    gorhill committed May 8, 2020
    Additionally, have the width of the page selector
    in the logger proportional to the width of the
    logger -- this should improve usability on small
    screen devices.
  2. Rerrange popup panel layout initializing code

    gorhill committed May 8, 2020
    Specifically, the sticky controls box is re-parented
    pre-emptively instead of waiting for the decision as
    to whether the panel must be toggled into a vertical
    layout mode.
  3. Make Firefox dev build auto-update

    gorhill committed May 8, 2020
You can’t perform that action at this time.