Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle nsp checks? #15

Closed
therealklanni opened this issue Jan 21, 2016 · 2 comments
Closed

How to handle nsp checks? #15

therealklanni opened this issue Jan 21, 2016 · 2 comments

Comments

@therealklanni
Copy link

@therealklanni therealklanni commented Jan 21, 2016

Do we want to integrate the nsp check into a "test" step and have PRs automatically fail if nsp check fails?

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 25, 2016

I'm in favor of that

@therealklanni
Copy link
Author

@therealklanni therealklanni commented Jan 26, 2016

OK, I've renamed the script to "test" (and "test-security" following convention set by @mrose17) so it will be ran in CI step. Someone just needs to enable Travis CI. 👍

@aekeus aekeus closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.