Skip to content

/ vault-updater

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 uploader script #4

Merged
merged 2 commits into from Jan 19, 2016
Merged

S3 uploader script #4

merged 2 commits into from Jan 19, 2016
+139 −0

Conversation

@aekeus
Copy link
Member

aekeus commented Jan 19, 2016

  • Inspects browser-laptop contents for available files
  • Sends to correct bucket from dist and win64-dist
  • Marks files as ACL available
aekeus added 2 commits Jan 19, 2016
@aekeus
S3 uploader script
8d91115 
  * Inspects browser-laptop contents for available files
  * Sends to correct bucket from dist and win64-dist
  * Marks files as ACL available
@aekeus
Merge branch 'master' into s3-uploader
92c9916
tools/uploader.js
console.log('Working with version: ' + version)

// Check for S3 env variables
if (!process.env.S3_KEY || !process.env.S3_SECRET) {

This comment has been minimized.

Sign in to view
Copy link
@bbondy

bbondy Jan 19, 2016

Member

I think you can have these cached locally, at least the scripts I did for simple-ec2 I didn't need to have them set. The access key and secret key could be omittied.
@bbondy
Copy link
Member

bbondy commented Jan 19, 2016

This is great, nice work!
bbondy added a commit that referenced this pull request Jan 19, 2016
@bbondy
Merge pull request #4 from brave/s3-uploader
e368fb7 
S3 uploader script
@bbondy bbondy merged commit e368fb7 into master Jan 19, 2016
tools/uploader.js
var async = require('async')

var args = require('yargs')
.usage('node tools/uploader.js --source=/full/directory/to/browser-laptop --send')

This comment has been minimized.

Sign in to view
Copy link
@bbondy

bbondy Jan 19, 2016

Member

Could you default this to ../browser-laptop if not specified?
Assuming would have both checked out side by side.

This comment has been minimized.

Sign in to view
Copy link
@aekeus

aekeus Jan 19, 2016

Author Member

Absolutely, good idea.

This comment has been minimized.

Sign in to view
Copy link
@bbondy

bbondy Jan 19, 2016

Member

If it causes any complications don't spend too much time on it, I'm fine putting my key in too via env var.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@aekeus @bbondy
You can’t perform that action at this time.