Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bitwarden 1.27.0 #60

Closed
wants to merge 1 commit into from
Closed

Update to Bitwarden 1.27.0 #60

wants to merge 1 commit into from

Conversation

@da2x
Copy link

da2x commented Jun 28, 2018

Resolves issue #48.

Resolves issue #48.
@Jacalz
Copy link

Jacalz commented Jun 28, 2018

It isn’t really as easy as just updating it here in the repo but I will go through and test in a couple days to see if the newer version works, as I usually do with Bitwarden updates. If it works without any hiccups, then it’s fine on my end but then it needs to be pushed to the server ands so on...

@da2x
Copy link
Author

da2x commented Jun 28, 2018

@Jacalz what is the update process then? Surely there is a process for detecting upstream updates and updating these extensions? Current version in Brave no longer syncs with Bitwarden.

@Jacalz
Copy link

Jacalz commented Jun 28, 2018

Yeah the way we do it is that me and @jonathansampson usually sit down and go through and try if there are any issues with the extensions and if there are non we update them. Bitwarden has not been getting updates due to time differences and being busy with other stuff... This will get solved though with Brave 1.0 that will be coming out later this year: https://github.com/brave/brave-browser

@Jacalz
Copy link

Jacalz commented Jul 1, 2018

It looks like the latest version works perfect without any issues, this is fine for me 👍

@bsclifton bsclifton requested a review from jonathansampson Jul 2, 2018
@Jacalz
Copy link

Jacalz commented Jul 10, 2018

I believe that this can be closed now since 2003524 is on the master branch now...

@bsclifton bsclifton closed this Jul 12, 2018
@kspearrin
Copy link

kspearrin commented Jul 27, 2018

@Jacalz How should we go about requesting an update review? For example, v1.28 was just released which contains some important updates that will cause breaking changes in older versions if not available in the future.

@Jacalz
Copy link

Jacalz commented Jul 27, 2018

@kspearin There isn’t really any process as to requesting reviews. I usually see the release and test it as soon as possible but then someone with acces to the sever needs to push it after I ask to get it updated. I will see if the new version works and if that’s the case, I will ask someone to update it hers and on the server🙂

@Jacalz
Copy link

Jacalz commented Jul 29, 2018

Bitwarden is now updated to latest 1.28.0 after some testing to ensure that it works. @kspearin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.