Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename code to node #525

Open
aomarks opened this issue Jan 29, 2024 · 8 comments
Open

Rename code to node #525

aomarks opened this issue Jan 29, 2024 · 8 comments

Comments

@aomarks
Copy link
Member

aomarks commented Jan 29, 2024

No description provided.

@aomarks aomarks added this to the M4 milestone Jan 29, 2024
@aomarks aomarks self-assigned this Jan 29, 2024
@aomarks aomarks changed the title Rename code to node Rename code to node Jan 29, 2024
@PaulKinlan
Copy link
Collaborator

What was the rational for this?

@aomarks
Copy link
Member Author

aomarks commented Jan 30, 2024

What was the rational for this?

I defer to @dglazkov + @seefeldb who I think made this decision (I didn't actually find the conversation yet, somewhere in Discord!). But, personally it seemed like a good idea to me. I think the recipe vs board distinction was kind of fuzzy, and it seems simpler to say "you make boards using the board function", without introducing another term.

@PaulKinlan
Copy link
Collaborator

right - I couldn't find the conversation either... I'm 100% on-board (heh) with board change. I'm not sure what node even means in this context, code made a lot more sense imo.

@aomarks
Copy link
Member Author

aomarks commented Jan 30, 2024

right - I couldn't find the conversation either... I'm 100% on-board (heh) with board change. I'm not sure what node even means in this context, code made a lot more sense imo.

Oh! Sorry, I thought this was about the recipe -> board change, my bad mixing up issues. Yes, I feel less convinced about the code -> node change, I also wanted to hear more before I made the change. I share a gut reaction that code is more intuitive, since it's the kind of node that runs code; not any kind of node.

@dglazkov
Copy link
Collaborator

code made a lot more sense imo.

tell me more. My intuition was that code produces a node factory, a literally "make a node" function.

@dglazkov
Copy link
Collaborator

Also, let's leave code as is for M4?

@dglazkov
Copy link
Collaborator

dglazkov commented Jan 30, 2024

another way I think of it: "if I had code function now, I would build some of the nodes in existing kits just as code.

Ah, I guess the difference in our perceptions:

  • "it allows me to add code to my board"

  • "it allows me to add custom nodes to my board"

@aomarks aomarks removed this from the M4 milestone Jan 31, 2024
@aomarks aomarks removed their assignment Jan 31, 2024
@PaulKinlan
Copy link
Collaborator

Right - it's more of the former. I certainly don't think of it in the sense of parts of kits in the reusable sense, I often default back to "I need to do something custom that is not worth making a kit for.. - code as kits is an interesting concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants