Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Python files in make-graphs #549

Merged
merged 5 commits into from Feb 2, 2024
Merged

Load Python files in make-graphs #549

merged 5 commits into from Feb 2, 2024

Conversation

kex103
Copy link
Collaborator

@kex103 kex103 commented Jan 31, 2024

Fixes #548 >

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@kex103 kex103 requested a review from dglazkov January 31, 2024 00:51
Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 4515c46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PaulKinlan
Copy link
Collaborator

Can we land the python stuff in the importer in the cli (which then will implicitly work with the cli's make)? ... and then have breadboard web consume the make exports in the CLI...?

@kex103
Copy link
Collaborator Author

kex103 commented Jan 31, 2024

Can we land the python stuff in the importer in the cli (which then will implicitly work with the cli's make)? ... and then have breadboard web consume the make exports in the CLI...?

Yeah, that would be fantastic.
I made an issue to track the breadboard-web loader: #555

If anyone is inclined, feel free to re-assign this issue. It'll be in my backlog for now.

@kex103 kex103 force-pushed the python-web branch 8 times, most recently from 93bcf45 to 0265a97 Compare February 2, 2024 21:23
@kex103 kex103 enabled auto-merge (squash) February 2, 2024 21:33
@kex103
Copy link
Collaborator Author

kex103 commented Feb 2, 2024

Looks like this PR always gets blocked because of the change to labs-prototype-ci.yml.
With the addition of python version, it looks like the check name changes, and now this PR gets blocked waiting for the old one, which never runs.

@kex103 kex103 merged commit bad5aa4 into main Feb 2, 2024
2 checks passed
@kex103 kex103 deleted the python-web branch February 2, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[breadboard-python] Load python board files in breadboard-web
3 participants