Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PushState issue with URL #184

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@dirkkelly
Copy link
Member

commented Apr 16, 2019

Fixes #173 by using replaceState instead of window.location

Reproduce

Acceptance

Upgrades the search to be query param based instead of hash based.

https://deploy-preview-184--breadtubetv.netlify.com/?q=contrap

Questions

  • Should we retain the hash based urls?

@jaymickey jaymickey referenced this pull request May 15, 2019

Merged

Global search #268

5 of 5 tasks complete

@dirkkelly dirkkelly closed this May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.