Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels Update #200

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
2 participants
@dirkkelly
Copy link
Member

commented Apr 19, 2019

Includes the YouTube provider description which we'll make more of in the future.

@dirkkelly dirkkelly requested review from jaymickey and breadtubetv/content Apr 19, 2019

@dirkkelly dirkkelly self-assigned this Apr 19, 2019

@dirkkelly dirkkelly force-pushed the channel-update branch from b0f455b to 667a32e Apr 19, 2019

@dirkkelly dirkkelly referenced this pull request Apr 28, 2019

Merged

Github Settings #249

@craiglonsdale
Copy link
Member

left a comment

There is a bit of inconsistency in these files that need to be fixed in the bake scripts.

@@ -6,8 +6,8 @@ providers:
name: azureScapegoat
slug: UCXIN3HIH0eon5hVYYpnoNuQ
url: https://www.youtube.com/channel/UCXIN3HIH0eon5hVYYpnoNuQ
description: ""
subscribers: 21950
description: Just your friendly neighborhood leftist cuck.

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

For consistency should this content be surrounded by quotation marks?

@@ -7,8 +7,9 @@ providers:
name: BadEmpanada
slug: UCUzmizB92LJ9oxf5T_snZNA
url: https://www.youtube.com/channel/UCUzmizB92LJ9oxf5T_snZNA
description: ""
subscribers: 1581
description: Hi! I make well-researched videos about world history, politics,

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

For consistency should this content be surrounded by quotation marks?

@@ -6,8 +6,10 @@ providers:
name: BadMouseProductions
slug: xaxie1
url: https://www.youtube.com/xaxie1
description: ""
subscribers: 64969
description: |-

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

Scuffed as symbols
also
For consistency should this content be surrounded by quotation marks?

@@ -7,8 +7,9 @@ providers:
name: Beau of the Fifth Column
slug: UC0YvoAYGgdOfySQSLcxtu1w
url: https://www.youtube.com/channel/UC0YvoAYGgdOfySQSLcxtu1w
description: ""
subscribers: 98331
description: The discussions of a southern journalist who is tired of a lack of

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

For consistency should this content be surrounded by quotation marks?

@@ -6,8 +6,8 @@ providers:
name: Benji Adam Whiskettes
slug: UCDG87s_QtD4YrIamqb9k5WQ
url: https://www.youtube.com/channel/UCDG87s_QtD4YrIamqb9k5WQ
description: ""
subscribers: 2922
description: So long and thanks for all the fish

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

For consistency should this content be surrounded by quotation marks?

@@ -6,8 +6,9 @@ providers:
name: Big Joel
slug: UCaN8DZdc8EHo5y1LsQWMiig
url: https://www.youtube.com/channel/UCaN8DZdc8EHo5y1LsQWMiig
description: ""
subscribers: 151117
description: I make video essays and deep dives about movies and other things.

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

For consistency should this content be surrounded by quotation marks?

@@ -7,7 +7,7 @@ providers:
slug: UCbbsW7_Esx8QZ8PgJ13pGxw
url: https://www.youtube.com/channel/UCbbsW7_Esx8QZ8PgJ13pGxw
description: ""

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

Purposefully left empty?

@@ -6,8 +6,8 @@ providers:
name: the Bronx Blogger
slug: UCxkk0VDNt0OJ3AZMNlRrGNg
url: https://www.youtube.com/channel/UCxkk0VDNt0OJ3AZMNlRrGNg
description: ""
subscribers: 1429
description: '"Justice is what love looks like in public" -Dr. Cornel West'

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

'". should maybe be "', or "'" lol i don't know

@@ -7,8 +7,17 @@ providers:
name: C0nc0rdance
slug: C0nc0rdance
url: https://youtube.com/C0nc0rdance
description: ""
subscribers: 54153
description: |-

This comment has been minimized.

Copy link
@craiglonsdale

craiglonsdale May 3, 2019

Member

scuffed as symbols
also
For consistency should this content be surrounded by quotation marks?

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Good questions @craiglonsdale. All a side effect of the yaml library we’re using in bake. @j16r has recommended another one. Hopefully we can have all descriptions output on new lines without the quote issues. Will merge this later today after re-updating the content to fix merge issues.

@dirkkelly dirkkelly force-pushed the channel-update branch from 0991739 to bdee1e1 May 3, 2019

@dirkkelly dirkkelly merged commit 38adea4 into master May 3, 2019

3 of 5 checks passed

Header rules - breadtubetv No header rules processed
Details
Pages changed - breadtubetv 26 new files uploaded
Details
Mixed content - breadtubetv No mixed content detected
Details
Redirect rules - breadtubetv 12 redirect rules processed
Details
netlify/breadtubetv/deploy-preview Deploy preview ready!
Details

@dirkkelly dirkkelly deleted the channel-update branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.