Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos Navigation #241

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
3 participants
@dirkkelly
Copy link
Member

commented Apr 27, 2019

Shows the videos on their own page, makes the navigation completely content related. Gives us the pages necessary to add video search and suggest features in the future.

https://deploy-preview-241--breadtubetv.netlify.com/videos/

Sort order is based on channel name presently, if we were able to get the video created dates through the bake command we could sort most recent first.

Screen Shot 2019-04-27 at 7 04 00 PM

Screen Shot 2019-04-27 at 7 04 05 PM

@dirkkelly dirkkelly requested a review from breadtubetv/development Apr 27, 2019

@dirkkelly dirkkelly self-assigned this Apr 27, 2019

@dirkkelly dirkkelly force-pushed the videos-navigation branch from bcb2975 to 8ab6a6a Apr 27, 2019

@dirkkelly dirkkelly force-pushed the videos-navigation branch from 8ab6a6a to 1165bac Apr 27, 2019

@ozzyaaron
Copy link

left a comment

LGTM!

Any thoughts on sorting videos by date at some point? Seems we'd need to add that to the yml for videos? Is that what bake is for? We'd probably need to re-scrape Youtube to get that data.

I'm willing to say I don't understand how playlist is doing the date sort - feel free to fill me in! - but I do see that's what this page is for :)

weight = 3

[[ menu.main ]]
name = "Blog"

This comment has been minimized.

Copy link
@ozzyaaron

ozzyaaron Apr 30, 2019

Going to keep the blog dirs and data around for later?

This comment has been minimized.

Copy link
@dirkkelly

dirkkelly May 1, 2019

Author Member

Yeah still gonna use them, they’re just linked in the footer instead

@jaymickey jaymickey merged commit eb5fc0d into master May 1, 2019

3 of 5 checks passed

Header rules - breadtubetv No header rules processed
Details
Pages changed - breadtubetv 1 new file uploaded
Details
Mixed content - breadtubetv No mixed content detected
Details
Redirect rules - breadtubetv 12 redirect rules processed
Details
netlify/breadtubetv/deploy-preview Deploy preview ready!
Details

@jaymickey jaymickey deleted the videos-navigation branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.