Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Settings #249

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@dirkkelly
Copy link
Member

commented Apr 28, 2019

Set GitHub configuration from the settings file, allows for democratic decision making around vital configuration.

Once we have this in I would like to discuss whether we can allow admins to merge without a review related to #147.

Current state of the project is very dependent on manual work of developers, including in the pull request process.

  • There are now notifications in Discord of submissions and pull requests
  • There is a pull request #200 to update content that is now 9 days old
  • Videos are being included in submission which gives context
  • There is now a link to r/BreadTube #247 search results for each submission

We still need to complete documentation, but the process is outlined in #248

Link to Chart
Screen Shot 2019-04-28 at 1 21 49 PM

@dirkkelly dirkkelly requested a review from breadtubetv/admins Apr 28, 2019

@dirkkelly dirkkelly self-assigned this Apr 28, 2019

allow_rebase_merge: true

# TODO Labels: define labels for Issues and Pull Requests
labels:

This comment has been minimized.

Copy link
@jaymickey

jaymickey Apr 30, 2019

Member

Does not including this mean that the bot will remove the existing labels?

This comment has been minimized.

Copy link
@dirkkelly

dirkkelly May 1, 2019

Author Member

Good call, dunno, removed the key and left the todo. It falls back to existing settings if not defined.

Update settings.yml
Removed labels definition

@dirkkelly dirkkelly requested a review from jaymickey May 1, 2019

@dirkkelly dirkkelly merged commit 478ec91 into master May 2, 2019

3 of 5 checks passed

Header rules - breadtubetv No header rules processed
Details
Pages changed - breadtubetv All files already uploaded
Details
Mixed content - breadtubetv No mixed content detected
Details
Redirect rules - breadtubetv 12 redirect rules processed
Details
netlify/breadtubetv/deploy-preview Deploy preview ready!
Details

@dirkkelly dirkkelly deleted the github-settings branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.