Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tags (not breadtube) on channels #264

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants

@dirkkelly dirkkelly force-pushed the channel-page-tags branch from 99b5468 to 2b4c306 May 10, 2019

@dirkkelly dirkkelly marked this pull request as ready for review May 10, 2019

@dirkkelly dirkkelly requested a review from breadtubetv/content May 10, 2019

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

Still need to show all tags when searching, but I think i need to refactor tags from data file to page file.

@jaymickey

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Appearance wise, it would be awesome if we could style them similar to bootstrap "labels" - https://www.w3schools.com/bootstrap/bootstrap_badges_labels.asp

I'm happy to work on this later when I get some time

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

Yeah I think we need a whole design pass on these pages

@jaymickey

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Did you want me to approve for now and improve later?

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

@jaymickey yeah be great to get this merged, thanks

@jaymickey jaymickey merged commit 4521f8a into master May 16, 2019

3 of 5 checks passed

Header rules - breadtubetv No header rules processed
Details
Pages changed - breadtubetv 173 new files uploaded
Details
Mixed content - breadtubetv No mixed content detected
Details
Redirect rules - breadtubetv 12 redirect rules processed
Details
netlify/breadtubetv/deploy-preview Deploy preview ready!
Details

@jaymickey jaymickey deleted the channel-page-tags branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.