Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search #268

Merged
merged 4 commits into from May 16, 2019

Conversation

Projects
None yet
3 participants

@dirkkelly dirkkelly force-pushed the global-search branch from 3ef8b32 to 8475ee0 May 10, 2019

dirkkelly added some commits May 10, 2019

@dirkkelly dirkkelly requested review from breadtubetv/development May 10, 2019

@dirkkelly dirkkelly force-pushed the global-search branch from 875387a to 2296d16 May 10, 2019

@craiglonsdale

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@dirkkelly any way we can fix this artefact?
image

@craiglonsdale

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@dirkkelly also noticed that if you type in the search, hitting the back button on the browser removes one character at a time making it a bit scuffed to navigate back/forward using the browser buttons. Any way we can put in some for of 'x' second delay before updating the browser bar?

@jaymickey

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@craiglonsdale - @dirkkelly has a PR in draft to fix that: #184

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

@craiglonsdale @jaymickey Can this be merged and then I can go back to fixing it in #184?

@jaymickey jaymickey merged commit c455503 into master May 16, 2019

3 of 5 checks passed

Header rules - breadtubetv No header rules processed
Details
Pages changed - breadtubetv All files already uploaded
Details
Mixed content - breadtubetv No mixed content detected
Details
Redirect rules - breadtubetv 12 redirect rules processed
Details
netlify/breadtubetv/deploy-preview Deploy preview ready!
Details

@jaymickey jaymickey deleted the global-search branch May 16, 2019

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

@craiglonsdale re that active thing, I had a PR once to remove it but it was flagged as an accessibility issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.