Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions Change: Admins Merge on data and content #282

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@dirkkelly
Copy link
Member

commented May 25, 2019

Currently all changes to the website require a review from at least one other person before being deployed. The change to this policy has been an open discussion since the #147 where a merge was forced through in order to support The Serfs during their time of being censored by Google.

Now that we have fully working scripts for downloading content I think we should move into a phase of rapid content changes to the site to allow for usage of the website in distribution, eg: tweeting a link to a breadtube channel page. This sort of functionality will be useful for a proof to concept to the community of the potentials for a website using this open source platform to monitor content in an "automated" way.

This is a request for change to permissions to allow admin merging without a review from anyone under certain committed conditions:

Admins can only merge for data/* and content/* changes, 24 hours after pull request, changes must not affect data structure.

Now that all changes are pushed to discord we have a way for all users to see the change requests and merges. We can use the revert feature in situations where there is conflict over whether the content should be merged.

I'd also happily discuss the restriction of not allowing new channels to be posted, this would fast track the regular updates and allow us to post videos on known channels without a review.

The goal would be to fully automate this process and eventually remove the review time restriction all together, allowing the website to respond in real time to content changes suggested via bots.

Feedback and discussion on this welcomed.

Thanks

Admins Merge on data and content
request for change to merge under certain agreed conditions

> Admins can only merge for data/* and content/* changes, 24 hours after pull request, changes must not affect data structure.

@dirkkelly dirkkelly added this to the Launch 1.0 milestone May 25, 2019

@dirkkelly dirkkelly self-assigned this May 25, 2019

@dirkkelly dirkkelly added this to In progress in Launch via automation May 25, 2019

@dirkkelly dirkkelly added this to In progress in Playlists via automation May 25, 2019

@dirkkelly dirkkelly added this to In progress in Import Scripts via automation May 25, 2019

@dirkkelly dirkkelly added this to In progress in Submission Forms via automation May 25, 2019

@jaymickey

This comment has been minimized.

Copy link
Member

commented May 25, 2019

Certainly support this change! I think extending this to new channels is fine as long as sufficient evidence exists that the channel fits with the purpose of BreadTube. (e.g. links to r/BreadTube would be a good start).

Launch automation moved this from In progress to Reviewer approved May 31, 2019

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

@breadtubetv/admins Is it possible to get a resolution on this Pull Request? We have PRs for simple content changes that are now 16 days old. Hopefully the onboarding stuff I'm writing now will also help this in the future, but at this point in time I think we need to be moving faster on content.

Thanks

@craiglonsdale craiglonsdale merged commit 06a908e into master Jun 10, 2019

3 of 5 checks passed

Header rules - breadtubetv No header rules processed
Details
Pages changed - breadtubetv 222 new files uploaded
Details
Mixed content - breadtubetv No mixed content detected
Details
Redirect rules - breadtubetv 12 redirect rules processed
Details
netlify/breadtubetv/deploy-preview Deploy preview ready!
Details

Launch automation moved this from Reviewer approved to Done Jun 10, 2019

Playlists automation moved this from In progress to Done Jun 10, 2019

Import Scripts automation moved this from In progress to Done Jun 10, 2019

Submission Forms automation moved this from In progress to Done Jun 10, 2019

@craiglonsdale craiglonsdale deleted the admin-merge-content branch Jun 10, 2019

@craiglonsdale

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Due to us all being exploited, sometimes we aren't getting enough time to go through the content and approve it all.
I imagine this issue will only get worse as the popularity of bread increases.

I support this, people who have proven to be trusted should be able to merge. There will be a trail of accountability if things start to go wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.