Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Submission Comments #293

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@dirkkelly
Copy link
Member

commented May 31, 2019

Screen Shot 2019-06-01 at 1 45 56 AM

https://deploy-preview-293--breadtubetv.netlify.com/contrapoints/

Adds better formatting to Channel Update, and a comment field to add and edit.

@dirkkelly dirkkelly requested review from breadtubetv/development May 31, 2019

@dirkkelly dirkkelly self-assigned this May 31, 2019

@jaymickey

This comment has been minimized.

Copy link
Member

commented May 31, 2019

If someone suggests an update to the channel description or name, isn't this going to be overwritten the next time bake update is run?

@dirkkelly

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

Description is outside of provider context and can be custom. Name is a less likely thing to be edited but again (I believe) is outside of the update script. If this is an issue I would suggest both top level name and description be create only from the scripts.

@jaymickey

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Fair enough, I will have to take a closer look when I get the chance. However, I think the best way to handle this is to pull the name/description on the initial import, but leave it alone on update.

@dirkkelly dirkkelly merged commit cc76d26 into master Jun 9, 2019

3 of 5 checks passed

Header rules - breadtubetv No header rules processed
Details
Pages changed - breadtubetv 377 new files uploaded
Details
Mixed content - breadtubetv No mixed content detected
Details
Redirect rules - breadtubetv 12 redirect rules processed
Details
netlify/breadtubetv/deploy-preview Deploy preview ready!
Details

@dirkkelly dirkkelly deleted the channel-comments branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.