Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Three bug fixes #1

Open
wants to merge 66 commits into from

6 participants

@novalis

I pulled a bug fix from keviniano's branch of master into the rails3 branch, and added two of my own. The minor fix is that tiny codes were being generated from a string that looked like "['a', 'b', 'c'...]" and thus had lots of brackets and such.

The major fix is that when you went back and edited an old section of the survey, old responses weren't being updated -- instead, new responses were added.

ignu and others added some commits
@ignu ignu Adding formtastic dependency to gemspec and edited README
edcdaf6
Mark Yoon making the formtastic dependency permanent via rakefile
6b37e32
@jdzak jdzak Added a conditional question group to the kitchen sink survey.
888b294
@jdzak jdzak Updated method to get unanswered dependencies within ResultSet to als…
…o return question groups.
31c0a44
@jdzak jdzak Saving response set completion time when a survey is finished.
bac06e0
Mark Yoon merging jdzak: Fixed pick one and pick any not saving when an answer …
…of type string exists within the options.
2164bc1
Mark Yoon Merged jdzak: Fixed problem with dropdowns inside of repeaters appear…
…ing as radio buttons.
6dc21b3
David Turner make tiny codes sane
2a4fd7a
David Turner bug fix from keviniano
5d992ae
David Turner do not duplicate answers in the database when redoing parts of a survey
420acc6
Mark Yoon add api ids
1f0c476
@gorenje gorenje rg is not an object, it's a fixnum
d360cc4
@gorenje gorenje need formtastic to create surveys
47cd0f4
@gorenje gorenje Merge remote branch 'nubic/rails3' into rails3
32989ed
@gorenje gorenje Merge commit '420acc6342b3596b3927' into rails3
fb292cc
@gorenje gorenje removed duplicate formtastic dependency
689703a
@gorenje gorenje Version bump to 0.16.2
d2a72ef
@Reprazent Reprazent Check if there is an answer id
36efee1
@Reprazent Reprazent Include the methods every time so they don't have to be reloaded afte…
…r parsing (Classes aren't reloaded in production)
589da04
@Reprazent Reprazent Changed to return the survey when parsed
05c1e77
@gorenje gorenje Version bump to 0.16.3
f16a1d3
@gorenje gorenje added require for uuid -- was causing a 'uninitialized constant Surve…
…yor::Models::SurveyMethods::UUID' error even though the gem was there
05f0282
@gorenje gorenje Version bump to 0.16.4
6deed2b
@gorenje gorenje removed deprecation warning
56087c9
@gorenje gorenje replaced erb with haml templates
25d5f64
@gorenje gorenje don't escape results
4f0e285
@gorenje gorenje display result only if it's an answer to the current question
7ce9e49
@gorenje gorenje Version bump to 0.16.5
1ccd1ef
@gorenje gorenje removed the last erb templates
e91b875
@gorenje gorenje show the results using a datatable from http://www.datatables.net/
76b76c8
@gorenje gorenje Version bump to 0.16.6
b04b5ad
@gorenje gorenje made the results a little more pretty
35ac033
@gorenje gorenje Version bump to 0.16.7
c3fbc6e
@gorenje gorenje handle saving string values correctly. Check for array first and then…
… continue, this was stopping simple string fields from being saved
25038af
@gorenje gorenje show just one result, not a whole change history
09b5593
@gorenje gorenje whitespace changes
941e840
@gorenje gorenje fixed a bug which meant that grid layout responses weren't being stor…
…ed in the database
d7956b1
@gorenje gorenje Version bump to 0.16.8
71525f9
@gorenje gorenje refactored code a little
1aef092
@gorenje gorenje fixed an issue where the last date was sent instead of the currently …
…choosen date for a date field
02e985e
@gorenje gorenje Version bump to 0.16.9
fb8c12f
@gorenje gorenje replaced erb template with haml template for the extending surveyor g…
…enerator
9dad351
@gorenje gorenje Version bump to 0.16.10
1b849fb
@gorenje gorenje removed a 's' from a regexp -- assume UTF-8 encoding and not Windows-31J
c890e24
David Turner Merge branches 'rails3' and 'rails3' of git://github.com/gorenje/surv…
…eyor into rails3
a24d83b
David Turner help text should not get its own number
f1a6cc1
Mathias Kutzner * remove previous answers if new answer is stored
 * change results display to show all results on pick any questions
b65e9b6
Mathias Kutzner * remove previous answers if new answer is stored
 * change results display to show all results on pick any questions
027bac9
@gorenje gorenje Version bump to 0.16.11
8a46e5b
Mathias Kutzner Merge remote-tracking branch 'upstream/rails3' into rails3
f62199f
Mathias Kutzner * activate and fix caching of sections
f5de8fc
@gorenje gorenje Version bump to 0.16.12
ab0370c
Mathias Kutzner * enable an app that uses the surveyor to change the parse_and_build…
… methods defined in lib/surveyor/parser.rb
375f467
@gorenje gorenje Merge pull request #2 from ewto/rails3
Rails3
b6d1e9a
@gorenje gorenje Version bump to 0.16.13
0244408
@yoon

Could you submit a new pull request to github.com/NUBIC/surveyor?

@novalis
Mathias Kutzner and others added some commits
Mathias Kutzner * bugfix for :pick => :any questions
   * if the last checkbox was deselected, the corresponding responses weren't removed
   * conditions (dependencies) depending on the corresponding question weren't fulfilled
1acfd75
@gorenje gorenje Merge pull request #3 from ewto/rails3
pick any fixes
935ae6f
@gorenje gorenje Version bump to 0.16.14
a7a7ba2
Mathias Kutzner * fix for issue described here gorenje@1acfd75#commitcomment-426669
 * do not remove answers that are still valid
 * don't try to merge answers with the destroy flag
1947036
@gorenje gorenje Merge pull request #4 from ewto/rails3
fix for the issues raised in gorenje@1acfd75
f4649ab
@gorenje gorenje Version bump to 0.16.15
also added a Gemfile and added some dependencies into the Rakefile.
7bc4e30
Mathias Kutzner * ensure no_responses_for_section? used for the caching is working p…
…roperly by setting the survey_section_id in an before_save callback
d60ad8d
@gorenje gorenje Merge pull request #5 from ewto/rails3
another change to fix the caching
c529676
@gorenje gorenje Version bump to 0.16.16
b4b606b
David Turner Merge branch 'rails3' of github.com:openplans/surveyor into rails3
6f4c83c
David Turner fix check for answer exists? (patch from keviniano)
de61510
@yoon

We've updated the breakpointer fork to show that NUBIC is now the blessed repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 26, 2011
  1. @ignu
Commits on Apr 20, 2011
  1. @jdzak

    Added a conditional question group to the kitchen sink survey.

    jdzak authored Mark Yoon committed
  2. @jdzak

    Updated method to get unanswered dependencies within ResultSet to als…

    jdzak authored Mark Yoon committed
    …o return question groups.
  3. @jdzak

    Saving response set completion time when a survey is finished.

    jdzak authored Mark Yoon committed
  4. merging jdzak: Fixed pick one and pick any not saving when an answer …

    Mark Yoon authored
    …of type string exists within the options.
  5. Merged jdzak: Fixed problem with dropdowns inside of repeaters appear…

    Mark Yoon authored
    …ing as radio buttons.
Commits on May 4, 2011
  1. make tiny codes sane

    David Turner authored
  2. bug fix from keviniano

    David Turner authored
Commits on May 6, 2011
Commits on May 9, 2011
  1. add api ids

    Mark Yoon authored
Commits on May 10, 2011
  1. @gorenje
  2. @gorenje
  3. @gorenje
  4. @gorenje
  5. @gorenje
  6. @gorenje

    Version bump to 0.16.2

    gorenje authored
  7. @Reprazent @gorenje

    Check if there is an answer id

    Reprazent authored gorenje committed
  8. @Reprazent @gorenje

    Include the methods every time so they don't have to be reloaded afte…

    Reprazent authored gorenje committed
    …r parsing (Classes aren't reloaded in production)
  9. @Reprazent @gorenje

    Changed to return the survey when parsed

    Reprazent authored gorenje committed
  10. @gorenje

    Version bump to 0.16.3

    gorenje authored
  11. @gorenje

    added require for uuid -- was causing a 'uninitialized constant Surve…

    gorenje authored
    …yor::Models::SurveyMethods::UUID' error even though the gem was there
  12. @gorenje

    Version bump to 0.16.4

    gorenje authored
  13. @gorenje

    removed deprecation warning

    gorenje authored
  14. @gorenje
  15. @gorenje

    don't escape results

    gorenje authored
  16. @gorenje
  17. @gorenje

    Version bump to 0.16.5

    gorenje authored
  18. @gorenje

    removed the last erb templates

    gorenje authored
  19. @gorenje
  20. @gorenje

    Version bump to 0.16.6

    gorenje authored
Commits on May 11, 2011
  1. @gorenje
  2. @gorenje

    Version bump to 0.16.7

    gorenje authored
  3. @gorenje

    handle saving string values correctly. Check for array first and then…

    gorenje authored
    … continue, this was stopping simple string fields from being saved
  4. @gorenje
  5. @gorenje

    whitespace changes

    gorenje authored
  6. @gorenje
  7. @gorenje

    Version bump to 0.16.8

    gorenje authored
Commits on May 12, 2011
  1. @gorenje

    refactored code a little

    gorenje authored
  2. @gorenje

    fixed an issue where the last date was sent instead of the currently …

    gorenje authored
    …choosen date for a date field
  3. @gorenje

    Version bump to 0.16.9

    gorenje authored
Commits on May 17, 2011
  1. @gorenje
  2. @gorenje

    Version bump to 0.16.10

    gorenje authored
  3. @gorenje
Commits on May 25, 2011
  1. Merge branches 'rails3' and 'rails3' of git://github.com/gorenje/surv…

    David Turner authored
    …eyor into rails3
  2. help text should not get its own number

    David Turner authored
Commits on Jun 3, 2011
  1. * remove previous answers if new answer is stored

    Mathias Kutzner authored
     * change results display to show all results on pick any questions
  2. @gorenje

    * remove previous answers if new answer is stored

    Mathias Kutzner authored gorenje committed
     * change results display to show all results on pick any questions
  3. @gorenje

    Version bump to 0.16.11

    gorenje authored
Commits on Jun 7, 2011
  1. Merge remote-tracking branch 'upstream/rails3' into rails3

    Mathias Kutzner authored
  2. * activate and fix caching of sections

    Mathias Kutzner authored
  3. @gorenje

    Version bump to 0.16.12

    gorenje authored
  4. * enable an app that uses the surveyor to change the parse_and_build…

    Mathias Kutzner authored
    … methods defined in lib/surveyor/parser.rb
Commits on Jun 8, 2011
  1. @gorenje

    Merge pull request #2 from ewto/rails3

    gorenje authored
    Rails3
  2. @gorenje

    Version bump to 0.16.13

    gorenje authored
Commits on Jun 10, 2011
  1. * bugfix for :pick => :any questions

    Mathias Kutzner authored
       * if the last checkbox was deselected, the corresponding responses weren't removed
       * conditions (dependencies) depending on the corresponding question weren't fulfilled
  2. @gorenje

    Merge pull request #3 from ewto/rails3

    gorenje authored
    pick any fixes
  3. @gorenje

    Version bump to 0.16.14

    gorenje authored
Commits on Jun 14, 2011
  1. * fix for issue described here gorenje@1acfd75#commitcomment-426669

    Mathias Kutzner authored
     * do not remove answers that are still valid
     * don't try to merge answers with the destroy flag
  2. @gorenje

    Merge pull request #4 from ewto/rails3

    gorenje authored
    fix for the issues raised in gorenje@1acfd75
  3. @gorenje

    Version bump to 0.16.15

    gorenje authored
    also added a Gemfile and added some dependencies into the Rakefile.
  4. * ensure no_responses_for_section? used for the caching is working p…

    Mathias Kutzner authored
    …roperly by setting the survey_section_id in an before_save callback
  5. @gorenje

    Merge pull request #5 from ewto/rails3

    gorenje authored
    another change to fix the caching
  6. @gorenje

    Version bump to 0.16.16

    gorenje authored
Commits on Jun 15, 2011
  1. fix check for answer exists? (patch from keviniano)

    David Turner authored
Something went wrong with that request. Please try again.