Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bref 2 dev images #38

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Bref 2 dev images #38

merged 4 commits into from
Dec 14, 2022

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented Dec 9, 2022

#5

While porting Bref 1 "dev" images to Bref 2, I was looking at how to improve the DX for users.

I think I managed to find an interesting result that combines all use cases into a single "dev" image that works out of the box, with xdebug and blackfire.

I recorded a video to show it in more details if you are interested: https://youtu.be/0PnreyR8c58

image

If you don't have time for the video, here's a quick example:

Bref v1

services:

    web:
        image: bref/fpm-dev-gateway
        ports:
            - '8000:80'
        volumes:
            - .:/var/task
        depends_on:
            - php
        environment:
            HANDLER: public/index.php
            DOCUMENT_ROOT: public

    app:
        image: bref/php-80-fpm-dev
        volumes:
            - .:/var/task

    console:
        image: bref/php-80
        volumes:
            - .:/var/task
        entrypoint: php

Bref v2

services:

    app:
        image: bref/php-80-fpm-dev
        ports: [ '8000:8000' ]
        volumes:
            - .:/var/task
        environment:
            HANDLER: public/index.php
            DOCUMENT_ROOT: public

@shadowhand
Copy link

I like running 1 less container 😃

@mnapoli mnapoli merged commit 692f1aa into main Dec 14, 2022
@mnapoli mnapoli deleted the dev-images branch December 14, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants