Allow setting PHP as a runtime in serverless.yml - #1394
Merged
Conversation
Contributor
Contributor
|
Only thing I could really see is that newcomers might also want additional layers (isn't But overall and assuming that this os properly documented, I'm all for! |
Member
Author
|
@afu-dev agreed, this is annoying to me as well. @georgeboot regarding extensions, I was thinking about something like this too: functions:
hello:
handler: ...
runtime: php-81
extensions:
- redis
- amqpWould that be better? (and yes we would need a clear error message in case users hit the layer limit) |
Contributor
Yup amazing! Could you cook it so that that would also enable the extension? 👀 |
Member
Author
|
Oh yes definitely! |
Member
Author
|
Note: will look into extensions separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TODO:
This new feature allows setting PHP as a runtime when deploying with
serverless.yml:This replaces the
layersvariables (which still work!). One could migrate to this new simpler syntax like this for example:service: myapp provider: name: aws - runtime: provided.al2 functions: function: handler: function.php - layers - - ${bref:layer.php-81} + runtime: php-81 api: handler: api.php - layers - - ${bref:layer.php-81-fpm} + runtime: php-81-fpm url: true plugins: - ./vendor/bref/brefThis removes several wtfs for beginners:
${bref:layer.php-81-fpm}syntaxRegarding the last one, indeed things get simpler for
console:functions: console: handler: bin/console - layers - - ${bref:layer.php-81} - - ${bref:layer.console} + runtime: php-81-consoleAnd also it makes switching to ARM much simpler too because the runtime stays the same, the layer is automatically switched to the ARM layer by the Bref plugin (it detects
architecture: arm64):