Skip to content
Browse files

Use a semicolon to separate frames

Use a semicolon instead of a comma to separate frames in the
flamegraph input.  Commas can appear in demangled C++ function
names (e.g. foo(int, int) ) so using commas to separate frames
can confuse the parser.
  • Loading branch information...
1 parent 2672d89 commit 02b07adf3bbaedc0e4caab1e8779e7dd40a5b7b8 Ryan Stone committed Jun 14, 2012
Showing with 5 additions and 5 deletions.
  1. +2 −2 flamegraph.pl
  2. +1 −1 stackcollapse-perf.pl
  3. +1 −1 stackcollapse-stap.pl
  4. +1 −1 stackcollapse.pl
View
4 flamegraph.pl
@@ -135,8 +135,8 @@ sub color {
sub flow {
my ($a, $b, $v) = @_;
- my @A = split ",", $a;
- my @B = split ",", $b;
+ my @A = split ";", $a;
+ my @B = split ";", $b;
my $len_a = $#A;
my $len_b = $#B;
View
2 stackcollapse-perf.pl
@@ -68,7 +68,7 @@ sub remember_stack {
chomp;
if (m/^$/) {
- remember_stack(join(",", @stack), 1) if @stack;
+ remember_stack(join(";", @stack), 1) if @stack;
undef @stack;
next;
}
View
2 stackcollapse-stap.pl
@@ -64,7 +64,7 @@ sub remember_stack {
chomp;
if (m/^\s*(\d+)+$/) {
- remember_stack(join(",", @stack), $1);
+ remember_stack(join(";", @stack), $1);
@stack = ();
next;
}
View
2 stackcollapse.pl
@@ -66,7 +66,7 @@ sub remember_stack {
chomp;
if (m/^\s*(\d+)+$/) {
- remember_stack(join(",", @stack), $1);
+ remember_stack(join(";", @stack), $1);
@stack = ();
next;
}

0 comments on commit 02b07ad

Please sign in to comment.
Something went wrong with that request. Please try again.