-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 AWSPager for ListObjects bug #218
Comments
Looks like fbc25dd broke it, which was designed to support a slightly newer pagination definition. I can't directly roll back, since the pagination format has changed, so I'll see if I can get a fix out shortly. |
brendanhay
added a commit
that referenced
this issue
Sep 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the old code that works (1.0.1)
This version (1.3.0) does not
The situation we see is that we have the first page return with a set of contents and a set of common prefixes. This page is the complete result we expect. NextMarker is
Nothing
as expected, truncated is set toJust False
. However the pager requests a new page because the contents is non empty (the new clause in the stop condition above + the missing truncated check). The generated code looks slightly off anyway because the second condition totally overlaps with the first by the looks of it anyway. The end result of this is that after calling paginate we end up with all the common prefixes returned twice (from the first page, and then the incorrect second page). Our experience with this API is the isTruncated is the only thing that can be trusted - nothing should be relying on the existence (or not) of next marker or contents.The text was updated successfully, but these errors were encountered: