-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to make unsigned requests #708
Conversation
53ebc78
to
9058031
Compare
I don't consider this critical for the 2.0 RC. If there's nothing else we need on that front, we should get it out the door first. Maybe if things are quiet during stabilisation we do this? The urgent question, I guess: are you happy with the
If so, then I think get the pieces lined up to make that possible (which shouldn't be much). As for avoiding partiality in the API: one way would be to add some type-level tags that track whether or not an |
The current dependency graph is:
And I understand your proposal as:
I'm probably misunderstanding, but is the additional library really necessary? Regarding |
9058031
to
3a4dbc1
Compare
This lets us use Env' inside Auth functions without an import cycle.
39feb9e
to
959fe7c
Compare
It is not. For some reason I thought generated services depended on After rewriting the @K0Te - Can you please test it when you get a chance? |
8d2e1c1
to
b7a7d5c
Compare
I do wonder if we should be parameterising the |
But OTOH people can create their own |
You were correct up until I fat-fingered 524fde6 on
That seems acceptable - It looks good to me, go ahead and merge whenever you're ready! |
b7a7d5c
to
6362d9a
Compare
Fixing a couple of documentation nits and giving @Fuuzetsu some well-deserved credit also, then will merge as soon as CI passes. |
CI takes ~3h and I built this locally. Hitting the merge button now. |
Add the ability to make unsigned requests. Tested by performing
s3:GetObject
against a bucket whose policy allowed access from"Principal": "*"
.Ping @K0Te , since this may be a better way to handle the
sts:AssumeRoleWithWebIdentity
stuff. It also lets us work towards anamazonka
/amazonka-auth
split down the line.Closes #702
Closes #602