Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upClean up implementation (step 3) #173
Conversation
tomaka
force-pushed the
tomaka:cleanup-3
branch
2 times, most recently
from
b43b551
to
6f1de1d
Sep 17, 2014
tomaka
added some commits
Sep 17, 2014
tomaka
force-pushed the
tomaka:cleanup-3
branch
from
dc4b457
to
5262992
Sep 18, 2014
tomaka
added some commits
Sep 18, 2014
tomaka
changed the title
[WIP] Clean up implementation (step 3)
Clean up implementation (step 3)
Sep 18, 2014
This comment has been minimized.
This comment has been minimized.
|
I'm happy merging this. |
This comment has been minimized.
This comment has been minimized.
|
I am going to re-run travis on this, but I think we should merge. Sorry for the delay. |
brendanzab
added a commit
that referenced
this pull request
Sep 21, 2014
brendanzab
merged commit ecad201
into
brendanzab:master
Sep 21, 2014
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
tomaka
deleted the
tomaka:cleanup-3
branch
Sep 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tomaka commentedSep 17, 2014
Generators are now building AST instead of strings
Most of the code uses
quote_*!macros, but some functions useecx.parse_itembecause quotes are unable to do what these functions want to do.Warning: compilation time
This PR doesn't seem to change considerably the compilation time of gl-rs (there seems to be a very minor reduction).
However on my local PC, compiling gl_generator goes from 9 seconds (before this PR) to 29 seconds (after).
Because of this change I'm not sure whether we should merge this.