Skip to content
This repository

App should work on all modern browsers #47

Closed
candera opened this Issue · 7 comments

1 participant

Craig Andera
Craig Andera
Collaborator

Background

At the moment, the application doesn't render correctly in IE, and has some oddities in Firefox 8. In order for the One to successfully demonstrate how to use ClojureScript to solve real-world problems, it's important that it function for all modern browsers. We define the list of require browsers to be:

  • Latest Safari (OS X)
  • Latest Google Chrome (Windows, OS X, Linux)
  • Latest Firefox (Windows, OS X, Linux)
  • Internet Explorer 8+ (Windows) (production mode only)

Acceptance Criteria

  • The application works equivalently in all required browsers

Tech Note

This should be one of the last issues that we address, to ensure that we're testing against any other changes that get made for the release.

Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Update to latest version of Domina. References #47. c8e640a
Craig Andera
Collaborator

We'll need to force IE9 out of compatibility/quirks mode and into IE9/standards mode in order for this to work.

Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera [WIP] Update to work with IE9. References #47. 44bf30c
Craig Andera
Collaborator

Figured out how to force IE9 out of quirks mode, but now we're seeing a problem where IE9 doesn't work in development mode, unless you're debugging. It appears to be some sort of weirdness related to using keywords as functions.

Craig Andera
Collaborator

We're parking this issue for now. We need to ask @redinger if it's sufficient for people to be able to use the app under IE, or if we have to support doing development. The reason it matters is that we've got production mode working right now under IE9, but not development mode.

Craig Andera
Collaborator

Got direction from @redinger: We should support IE8+. Supporting IE7 will require changes to ClojureScript itself.

Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Update to latest version of Domina.
References #47.
210248c
Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Updates to support IE8.
- Implement protocols on Element rather than HTMLElement
- Use alternate strategy for retrieving styles/opacity
- References #47.
fc36995
Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Updates to support IE8.
- Call single-node on results of by-class to work around issue with
  IE8 throwing error "No protocol method ISeqable.-seq defined for
  type object: [object StaticNodeList]"
- References #47.
a1128f9
Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Updates to support IE8...
- Animate hiding of label as well as form.
- References #47.
bf9921d
Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera [WIP] Address form/cross-fade...
- Sort of hacky half-solution. We probably want to refactor this to
  handle things correctly by making the layout make more sense.
- References #47
71f9425
Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Updates to support IE9...
- Disable name-input after transitioning to greeting view.
- References #47.
5da4262
Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Fix initial label alignment in Chrome. References #47. 4829b62
Craig Andera
Collaborator

Review of r159:

OS Browser Status
Windows IE9 Greeting page in design view blank
Windows Firefox "

Aborted review.

Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Fix button failing to fade in IE8. References #47. 943243d
Craig Andera
Collaborator

Review of r161:

OS Browser Status
Windows IE9 OK
Windows Firefox 9 OK
Windows Chrome OK
Ubuntu Firefox 8 Text field off-center on form design/dev/production pages
Ubuntu Chromium OK
Craig Andera candera referenced this issue from a commit
Brenton Ashworth and Craig Andera Label now fades when input is valid. References #47. bfafe96
Craig Andera
Collaborator

Review of r161:

OS Browser Status
Windows IE9 OK
Windows Firefox 9 OK
Windows Chrome OK
Ubuntu Firefox 8 OK*
Ubuntu Chromium OK
OS X Safari OK
OS X Firefox OK
OS X Chrome OK

(*) Text field off-center on form design/dev/production pages

Verdict: pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.