Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more nil checks in plotly sugar #35

Merged
merged 1 commit into from Jan 10, 2019
Merged

more nil checks in plotly sugar #35

merged 1 commit into from Jan 10, 2019

Conversation

Vindaar
Copy link
Member

@Vindaar Vindaar commented Jan 10, 2019

I stumbled on a typo in gridColorY in plotly sugar and added some missing nil checks for Marker causing a SIGSEGV if no marker existed.
Also removes a duplicate proc (oops...).

brentp
brentp reviewed Jan 10, 2019
View reviewed changes
Copy link
Collaborator

@brentp brentp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vindaar Vindaar merged commit d0e708c into SciNim:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentp brentp brentp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vindaar @brentp