Skip to content

Commit

Permalink
* test/ruby/test_m17n_comb.rb (TestM17NComb::test_str_chomp): test
Browse files Browse the repository at this point in the history
  updated.

git-svn-id: http://svn.ruby-lang.org/repos/ruby/trunk@15644 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
matz committed Feb 29, 2008
1 parent 88d156a commit a7862b6
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
5 changes: 5 additions & 0 deletions ChangeLog
@@ -1,3 +1,8 @@
Fri Feb 29 23:14:38 2008 Yukihiro Matsumoto <matz@ruby-lang.org>

* test/ruby/test_m17n_comb.rb (TestM17NComb::test_str_chomp): test
updated.

Fri Feb 29 20:58:09 2008 Yukihiro Matsumoto <matz@ruby-lang.org>

* test/ruby/test_iterator.rb (TestIterator::test_enumerator):
Expand Down
2 changes: 1 addition & 1 deletion string.c
Expand Up @@ -5357,11 +5357,11 @@ rb_str_chomp_bang(int argc, VALUE *argv, VALUE str)
if (rslen == 1 && newline == '\n')
goto smart_chomp;

enc = rb_enc_check(str, rs);
if (is_broken_string(rs)) {
return Qnil;
}
pp = e - rslen;
enc = rb_enc_check(str, rs);
if (p[len-1] == newline &&
(rslen <= 1 ||
memcmp(RSTRING_PTR(rs), pp, rslen) == 0)) {
Expand Down
8 changes: 6 additions & 2 deletions test/ruby/test_m17n_comb.rb
Expand Up @@ -720,8 +720,10 @@ def test_str_rjust

def test_str_chomp
combination(STRINGS, STRINGS) {|s1, s2|
if !s1.ascii_only? && !s2.ascii_only? && s1.encoding != s2.encoding
assert_raise(ArgumentError) { s1.chomp(s2) }
if !s1.ascii_only? && !s2.ascii_only? && !Encoding.compatible?(s1,s2)
if s1.bytesize > s2.bytesize
assert_raise(ArgumentError) { s1.chomp(s2) }
end
next
end
t = enccall(s1, :chomp, s2)
Expand Down Expand Up @@ -1425,6 +1427,7 @@ def test_str_sub
assert_equal(s1, doit.call)
next
end
assert(false, "test broken")
if !str_enc_compatible?(s1.gsub(r2, ''), s3)
assert_raise(ArgumentError, desc) { doit.call }
next
Expand Down Expand Up @@ -1479,6 +1482,7 @@ def test_str_sub!
assert_equal([s1, nil], doit.call)
next
end
assert(false, "test broken")
if !str_enc_compatible?(s1.gsub(r2, ''), s3)
assert_raise(ArgumentError, desc) { doit.call }
next
Expand Down

0 comments on commit a7862b6

Please sign in to comment.