New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting using 'No hits' gets messed up #21

Closed
bretonics opened this Issue Jan 27, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@bretonics
Owner

bretonics commented Jan 27, 2017

After fixing issue #20, the removal of CRISPRs with 'No Hits' results in removing them completely when sorting on line 337.

#20 fixes 'undef' issue, but introduces bug where CRISPR may not necessarily be missing in all subject sequences (not only from the singular subject where it is not found). Currently it completely omits those others.

Searching CRISPR targets against subject_1
CRISPR_22 has 0 hits here
CRISPR_50 has 0 hits here
CRISPR_72 has 0 hits here
CRISPR_93 has 0 hits here
CRISPR_129 has 0 hits here

Searching CRISPR targets against subject_2
CRISPR_25 has 0 hits here
CRISPR_91 has 0 hits here

So instead of omitting CRISPRS 22, 50, 72, 93, 129 only for subject_1, it does it for all subjects.

If 'No Hits' CRISPRs are not removed, sorting fails. Conundrum.

@bretonics bretonics added the bug label Jan 27, 2017

bretonics added a commit that referenced this issue Jan 27, 2017

bretonics added a commit that referenced this issue Jan 27, 2017

@bretonics bretonics closed this in 3ffa2b2 Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment