From 22f98f98807490cef5d66665fcc90947555fc05f Mon Sep 17 00:00:00 2001 From: Brett Beutell Date: Fri, 14 Jul 2023 13:59:06 +0200 Subject: [PATCH] Fix test_non_monotonic_sum_to_prometheus after changes from #3279 --- .../tests/test_prometheus_exporter.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py b/exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py index 1a648012c4..a9ab05d01e 100644 --- a/exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py +++ b/exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py @@ -128,7 +128,7 @@ def test_histogram_to_prometheus(self): def test_monotonic_sum_to_prometheus(self): labels = {"environment@": "staging", "os": "Windows"} metric = _generate_sum( - "test@sum", + "test@sum_monotonic", 123, attributes=labels, description="testdesc", @@ -156,7 +156,9 @@ def test_monotonic_sum_to_prometheus(self): for prometheus_metric in collector.collect(): self.assertEqual(type(prometheus_metric), CounterMetricFamily) - self.assertEqual(prometheus_metric.name, "test_sum_testunit") + self.assertEqual( + prometheus_metric.name, "test_sum_monotonic_testunit" + ) self.assertEqual(prometheus_metric.documentation, "testdesc") self.assertTrue(len(prometheus_metric.samples) == 1) self.assertEqual(prometheus_metric.samples[0].value, 123) @@ -171,7 +173,7 @@ def test_monotonic_sum_to_prometheus(self): def test_non_monotonic_sum_to_prometheus(self): labels = {"environment@": "staging", "os": "Windows"} metric = _generate_sum( - "test@sum", + "test@sum_nonmonotonic", 123, attributes=labels, description="testdesc", @@ -195,12 +197,14 @@ def test_non_monotonic_sum_to_prometheus(self): ] ) - collector = _CustomCollector() + collector = _CustomCollector(disable_target_info=True) collector.add_metrics_data(metrics_data) for prometheus_metric in collector.collect(): self.assertEqual(type(prometheus_metric), GaugeMetricFamily) - self.assertEqual(prometheus_metric.name, "test_sum_testunit") + self.assertEqual( + prometheus_metric.name, "test_sum_nonmonotonic_testunit" + ) self.assertEqual(prometheus_metric.documentation, "testdesc") self.assertTrue(len(prometheus_metric.samples) == 1) self.assertEqual(prometheus_metric.samples[0].value, 123)