Allow creating KDBs from scratch, added setup.py for pip install#9
Merged
Conversation
Added Nose test discovery to setup.py. Added keepassc.py to setup.py.
Corrected license file: it was a reference to GPLv2+ followed by the old NetBSD with attribution license, but since all the other files have GPLv2+ comments at the top, I believe this to be a mistake.
No longer updates access time for every node while reading the file.
Owner
|
Looks good. Thanks! |
brettviren
added a commit
that referenced
this pull request
Jun 22, 2013
Allow creating KDBs from scratch, added setup.py for pip install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a lot of broken or missing stuff that was preventing me from creating KDB files from scratch using your library. I've also added a setup.py file to allow
pip installto work with this package, updated the tests that were working to be runnable fromnoseorpy.test, and added a new test that creates a fresh KDB, writes it, and then reads it back.Thanks for your work on this. It's really handy to have a KDB reader/writer that works with Python 2.7 and is GPLv2 rather than v3.