From c742e86838c71019891f8fe6a9d84e40ff07ff32 Mon Sep 17 00:00:00 2001 From: Brett Wooldridge Date: Wed, 23 Jan 2019 01:21:00 +0900 Subject: [PATCH] Do not log warning about idleTimeout unless minimumIdle is less than maxPoolSize (because otherwise it does not apply) --- src/main/java/com/zaxxer/hikari/HikariConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/zaxxer/hikari/HikariConfig.java b/src/main/java/com/zaxxer/hikari/HikariConfig.java index a2ff0d229..613b4a96a 100644 --- a/src/main/java/com/zaxxer/hikari/HikariConfig.java +++ b/src/main/java/com/zaxxer/hikari/HikariConfig.java @@ -973,7 +973,7 @@ private void validateNumerics() maxLifetime = MAX_LIFETIME; } - if (idleTimeout + SECONDS.toMillis(1) > maxLifetime && maxLifetime > 0) { + if (idleTimeout + SECONDS.toMillis(1) > maxLifetime && maxLifetime > 0 && minIdle < maxPoolSize) { LOGGER.warn("{} - idleTimeout is close to or more than maxLifetime, disabling it.", poolName); idleTimeout = 0; }