New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Javassist-3.19.0-GA #223

Closed
wants to merge 3 commits into
base: 2.2.5
from

Conversation

Projects
None yet
2 participants
@takahashikzn

takahashikzn commented Jan 7, 2015

VerifyError occurs when update to Javassist-3.19.0-GA as follows.
Java8's default methods should be ignored to avoid this issue.

Caused by: java.lang.VerifyError: Illegal type at constant pool entry 417 in class com.zaxxer.hikari.proxy.PreparedStatementJavassistProxy
Exception Details:
  Location:
    com/zaxxer/hikari/proxy/PreparedStatementJavassistProxy.setObject(ILjava/lang/Object;Ljava/sql/SQLType;)V @4: invokespecial
  Reason:
    Constant pool index 417 is invalid
  Bytecode:
    0x0000000: 2a1b 2c2d b701 a1a7 000c 3a04 2a19 04b6
    0x0000010: 001b bfb1                              
  Exception Handler Table:
    bci [0, 7] => handler: 10
  Stackmap Table:
    full_frame(@10,{Object[#2],Integer,Object[#285],Object[#412]},{Object[#17]})
    same_frame(@19)

    at com.zaxxer.hikari.proxy.ProxyFactory.getProxyPreparedStatement(ProxyFactory.java) ~[HikariCP-2.2.5.jar:na]
    at com.zaxxer.hikari.proxy.ConnectionProxy.prepareStatement(ConnectionProxy.java:280) ~[HikariCP-2.2.5.jar:na]
    at com.zaxxer.hikari.proxy.ConnectionJavassistProxy.prepareStatement(ConnectionJavassistProxy.java) ~[HikariCP-2.2.5.jar:na]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_25]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_25]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_25]
    at java.lang.reflect.Method.invoke(Method.java:483) ~[na:1.8.0_25]
@takahashikzn

This comment has been minimized.

Show comment
Hide comment
@takahashikzn

takahashikzn Jan 7, 2015

I'm sorry for that the commit '2fe2c81' should not be included, because java.lang.reflect.Method#isDefault() is available only Jre8 or later.

takahashikzn commented Jan 7, 2015

I'm sorry for that the commit '2fe2c81' should not be included, because java.lang.reflect.Method#isDefault() is available only Jre8 or later.

brettwooldridge added a commit that referenced this pull request Jan 8, 2015

@brettwooldridge

This comment has been minimized.

Show comment
Hide comment
@brettwooldridge

brettwooldridge Jan 8, 2015

Owner

作ってくれたパッチをありがとうございました。

Owner

brettwooldridge commented Jan 8, 2015

作ってくれたパッチをありがとうございました。

@takahashikzn

This comment has been minimized.

Show comment
Hide comment
@takahashikzn

takahashikzn Jan 8, 2015

こちらこそありがとうございました。

ところで、よく考えたら"revert commit '2fe2c8143810abc4cf13579f4a2f3890b3040598'" は不要でしたね。READMEをよく読んでおくべきでした。

HikariCPは仕事でとても役に立っているので、また貢献させていただきます。

takahashikzn commented Jan 8, 2015

こちらこそありがとうございました。

ところで、よく考えたら"revert commit '2fe2c8143810abc4cf13579f4a2f3890b3040598'" は不要でしたね。READMEをよく読んでおくべきでした。

HikariCPは仕事でとても役に立っているので、また貢献させていただきます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment