Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Kill dead online components" breaks the Qt5 build #62

Closed
sl1pkn07 opened this issue Dec 26, 2015 · 4 comments
Closed

Revert "Kill dead online components" breaks the Qt5 build #62

sl1pkn07 opened this issue Dec 26, 2015 · 4 comments
Assignees
Labels
Bug
Milestone

Comments

@sl1pkn07
Copy link

@sl1pkn07 sl1pkn07 commented Dec 26, 2015

Hi (and Merry Chrismas)

the commit c9e3cae break the build with Qt5

-DWITH_WINEAPPDB=OFF can't help

In file included from /tmp/makepkg/q4wine-git/src/q4wine/src/core/httpcore.cpp:19:0:
/tmp/makepkg/q4wine-git/src/q4wine/src/core/httpcore.h:27:17: fatal error: QHttp: No such file or directory
compilation terminated.
src/q4wine-gui/CMakeFiles/q4wine.dir/build.make:647: recipe for target 'src/q4wine-gui/CMakeFiles/q4wine.dir/__/core/httpcore.cpp.o' failed
make[2]: *** [src/q4wine-gui/CMakeFiles/q4wine.dir/__/core/httpcore.cpp.o] Error 1

greetings

@brezerk brezerk added the Bug label Dec 26, 2015
@brezerk brezerk added this to the 1.2 milestone Dec 26, 2015
@brezerk brezerk self-assigned this Dec 26, 2015
@brezerk
Copy link
Owner

@brezerk brezerk commented Dec 26, 2015

Merry Chrismas! :)

Yeah. It seems for QT5 we should use QNetworkAccessManager instead. Will look into it.

@brezerk
Copy link
Owner

@brezerk brezerk commented Dec 26, 2015

There are two issues:

  1. Use QNetworkAccessManager instead of QHttp: fixed by fdf9a15
  2. Do not try to build wineappdb's dependencies in case of '-DWITH_WINEAPPDB=OFF' will be fixed lately.
@brezerk
Copy link
Owner

@brezerk brezerk commented Dec 26, 2015

second issue is fixed too: ea45aa1

reopen if needed. tanks for the report and have a nice weekend.

@brezerk brezerk closed this Dec 26, 2015
@sl1pkn07
Copy link
Author

@sl1pkn07 sl1pkn07 commented Dec 26, 2015

thanks a lot. now builds all ok

have you a great weekend (and rest of chrismas) too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.