Revert "Kill dead online components" breaks the Qt5 build #62

Closed
sl1pkn07 opened this Issue Dec 26, 2015 · 4 comments

Projects

None yet

2 participants

@sl1pkn07

Hi (and Merry Chrismas)

the commit c9e3cae break the build with Qt5

-DWITH_WINEAPPDB=OFF can't help

In file included from /tmp/makepkg/q4wine-git/src/q4wine/src/core/httpcore.cpp:19:0:
/tmp/makepkg/q4wine-git/src/q4wine/src/core/httpcore.h:27:17: fatal error: QHttp: No such file or directory
compilation terminated.
src/q4wine-gui/CMakeFiles/q4wine.dir/build.make:647: recipe for target 'src/q4wine-gui/CMakeFiles/q4wine.dir/__/core/httpcore.cpp.o' failed
make[2]: *** [src/q4wine-gui/CMakeFiles/q4wine.dir/__/core/httpcore.cpp.o] Error 1

greetings

@brezerk brezerk added the Bug label Dec 26, 2015
@brezerk brezerk added this to the 1.2 milestone Dec 26, 2015
@brezerk brezerk self-assigned this Dec 26, 2015
@brezerk
Owner
brezerk commented Dec 26, 2015

Merry Chrismas! :)

Yeah. It seems for QT5 we should use QNetworkAccessManager instead. Will look into it.

@brezerk
Owner
brezerk commented Dec 26, 2015

There are two issues:

  1. Use QNetworkAccessManager instead of QHttp: fixed by fdf9a15
  2. Do not try to build wineappdb's dependencies in case of '-DWITH_WINEAPPDB=OFF' will be fixed lately.
@brezerk
Owner
brezerk commented Dec 26, 2015

second issue is fixed too: ea45aa1

reopen if needed. tanks for the report and have a nice weekend.

@brezerk brezerk closed this Dec 26, 2015
@sl1pkn07

thanks a lot. now builds all ok

have you a great weekend (and rest of chrismas) too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment