New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat aarch64 as 64 bit platform and put libraries in lib64 directory #85

Closed
nullr0ute opened this Issue Aug 21, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@nullr0ute

nullr0ute commented Aug 21, 2016

Bug-50 (according to the changelog) added support for lib64 for x86_64. aarch64 is also supported by wine is a 64 bit platform and should be treated the same.

@brezerk brezerk added the Bug label Aug 21, 2016

@brezerk brezerk added this to the 1.3.2 milestone Aug 21, 2016

@brezerk brezerk self-assigned this Aug 21, 2016

@brezerk brezerk added New feature Improvement and removed Bug labels Aug 21, 2016

@brezerk

This comment has been minimized.

Show comment
Hide comment
@brezerk

brezerk Aug 21, 2016

Owner

Hi @nullr0ute

Not sure what I need to do here. BUG-50 intended to simplify wine lib's configuration for q4wine, by allowing Wine itself to care of this. So this settings are optional for q4wine currently (as for 1.3.x).

I have no aarch64 system to test unfortunately can you clarify the issue and requirements please?

Thanks.

Owner

brezerk commented Aug 21, 2016

Hi @nullr0ute

Not sure what I need to do here. BUG-50 intended to simplify wine lib's configuration for q4wine, by allowing Wine itself to care of this. So this settings are optional for q4wine currently (as for 1.3.x).

I have no aarch64 system to test unfortunately can you clarify the issue and requirements please?

Thanks.

@nullr0ute

This comment has been minimized.

Show comment
Hide comment
@nullr0ute

nullr0ute Aug 21, 2016

Basically the libs need to be installed into /usr/lib64/ instead of /usr/lib/ when the architecture is aarch64. Full build logs here of a aarch64 build. Happy to test any patches etc

http://arm.koji.fedoraproject.org/kojifiles/work/tasks/3038/3683038/build.log

nullr0ute commented Aug 21, 2016

Basically the libs need to be installed into /usr/lib64/ instead of /usr/lib/ when the architecture is aarch64. Full build logs here of a aarch64 build. Happy to test any patches etc

http://arm.koji.fedoraproject.org/kojifiles/work/tasks/3038/3683038/build.log

@brezerk

This comment has been minimized.

Show comment
Hide comment
@brezerk

brezerk Aug 21, 2016

Owner

Hi @nullr0ute,

Thanks for clarifications!

This commit 33939d9 change cmake build script logic to set target directory to the /usr/lib64/ when the architecture is aarch64.

Let me know if it works for you or not ( I hope it does :) )

Owner

brezerk commented Aug 21, 2016

Hi @nullr0ute,

Thanks for clarifications!

This commit 33939d9 change cmake build script logic to set target directory to the /usr/lib64/ when the architecture is aarch64.

Let me know if it works for you or not ( I hope it does :) )

@nullr0ute

This comment has been minimized.

Show comment
Hide comment
@nullr0ute

nullr0ute Aug 21, 2016

Looks good! Thanks for the quick response :)

nullr0ute commented Aug 21, 2016

Looks good! Thanks for the quick response :)

@brezerk

This comment has been minimized.

Show comment
Hide comment
@brezerk

brezerk Aug 21, 2016

Owner

Thanks for reporting and testing!

Owner

brezerk commented Aug 21, 2016

Thanks for reporting and testing!

@brezerk brezerk closed this Aug 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment