Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console launch environment uses dead setting fields #90

Closed
RomanHargrave opened this issue Oct 16, 2016 · 2 comments
Closed

Console launch environment uses dead setting fields #90

RomanHargrave opened this issue Oct 16, 2016 · 2 comments
Assignees
Labels

Comments

@RomanHargrave
Copy link
Contributor

@RomanHargrave RomanHargrave commented Oct 16, 2016

When launching a console within a prefix, q4wine sets several variables that are useful for scripts, etc, which need to know information about what version of wine is needed for a session.

q4wine attempts to add some of those, but ultimately fails as the routine which launches the terminal does not use what I assume is the new version management system and instead expects specific setting fields to be populated.

sh_args << "env";
sh_args << QString("WINEPREFIX=%1").arg(prefix_info.value("path"));
if (!prefix_info.value("libs").isEmpty())
    sh_args << QString("WINEDLLPATH=%1").arg(prefix_info.value("libs"));
sh_args << QString("WINELOADER=%1").arg(prefix_info.value("loader"));
sh_args << QString("WINESERVER=%1").arg(prefix_info.value("server"));
if (!prefix_info.value("arch").isEmpty())
    sh_args << QString("WINEARCH=%1").arg(prefix_info.value("arch"));
@RomanHargrave RomanHargrave changed the title Console launch environment is broken Console launch environment uses dead setting fields Oct 16, 2016
@brezerk
Copy link
Owner

@brezerk brezerk commented Oct 16, 2016

Hi @RomanHargrave which one wine version are you using?

From what I see this settings are still actual for 1.9.21 also they are listed in the official wiki https://www.winehq.org/docs/wine

@brezerk brezerk self-assigned this Oct 16, 2016
@brezerk
Copy link
Owner

@brezerk brezerk commented Oct 16, 2016

Oh. Never mind i got your message now :)

This commit should fix the issue 2db0bb0

Thanks a lot for reporting. Reopen if needed.

@brezerk brezerk closed this Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.