Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of env causing issues with wine kill #143

Merged
merged 1 commit into from May 3, 2019

Conversation

@nairaner
Copy link

nairaner commented Apr 20, 2019

"\0" causes string to be split into single characters. (Qt 5.12.2 and happened for some time)
It was changed in 22adeb7
This should fix both issues

Failure to start wineserver caused crash, because it tried to use LANG instead of encoding type

Fix crash caused by using LANG instead of encoding
@brezerk brezerk added the Bug label Apr 20, 2019
@brezerk brezerk self-assigned this Apr 20, 2019
@brezerk brezerk requested a review from tehnick Apr 20, 2019
@brezerk
brezerk approved these changes May 3, 2019
Copy link
Owner

brezerk left a comment

Sorry for late review. Looks good. Thank you.!

@brezerk brezerk merged commit 2ff6a9e into brezerk:master May 3, 2019
@tehnick

This comment has been minimized.

Copy link
Collaborator

tehnick commented May 3, 2019

@brezerk
Sorry, I was busy with other projects and completely forgot about this PR...

@nairaner
Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.