Four4Sample - Handle "underflow" of numerator in multiply

brian-dot-net · Mar 17, 2018 · e8ffde3 · e8ffde3
1 parent 7229bdb
commit e8ffde3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/projects/Four4Sample/Four4.Test/EvalTest.cs b/projects/Four4Sample/Four4.Test/EvalTest.cs
@@ -161,6 +161,7 @@ public void Exponent(string input, string result)
         [InlineData("3 ! ! 3 ^", "373248000")]
         [InlineData("3 ! ! 3 ^ .3 /", "NaN")]
         [InlineData("3 ! ! 3 ^ .3 / 3 ^", "NaN")]
+        [InlineData("3 ! ! 3 ^ .3 33 - /", "NaN")]
         public void ExpressionsWith3(string input, string result)
         {
             Test(input, result);

diff --git a/projects/Four4Sample/Four4/Number.cs b/projects/Four4Sample/Four4/Number.cs
@@ -62,7 +62,7 @@ public Number(int num, int denom)
         public static Number operator *(Number left, Number right)
         {
             double nr = (double)left.num * right.num;
-            if (nr > int.MaxValue)
+            if ((nr > int.MaxValue) || (nr < int.MinValue))
             {
                 return NaN;
             }