[MRG] Allow the use of "if" in the shorthand generator syntax #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this a while ago but never got around fixing it.
At the moment, the short-hand generator syntax (for single targets per source) does not work with
if
, because something likeconnect(j='i if i % 2 == 0')
is translated intoi if i % 2 == 0 for _ in range(1)
.My commit is a bit of a quick fix, I think we should probably include the parsing of the short-hand code into the
parse_generator_syntax
function in the long run to make the code easier to follow.Either way, I'd be happy if this could be merged as a short-term solution, I have a use case for this and writing
for _ in range(1)
is really ugly...