New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpikeMonitor for subgroups (weave, cython, cpp_standalone) #454

Merged
merged 1 commit into from Apr 21, 2015

Conversation

Projects
None yet
3 participants
@mstimberg
Member

mstimberg commented Apr 21, 2015

For subgroups not starting at 0, the code for searching through the list of all spikes for spikes that should be recorded was not correct. If some neuron in the full group spiked, but none of them >= the start index of the recorded subgroup, then all (instead of none) spikes were recorded. The good news is that this should not have led to undetected incorrect recordings because 1) it would have recorded spikes with negative indices, which would be incorrect in an obvious way and 2) it most of the time should have led to a segmentation fault due to accessing the _count array with negative indices (this is the way I encountered the issue). Nevertheless, an important bug.

Fix SpikeMonitor for subgroups (weave, cython, cpp_standalone)
For subgroups not starting at 0, the code for searching through the list of all spikes for spikes that should be recorded was not correct. If some neuron in the full group spiked, but none of them >= the start index of the recorded subgroup, then all (instead of none) spikes were recorded. The good news is that this should not have led to undetected incorrect recordings because 1) it would have recorded spikes with negative indices, which would be incorrect in an obvious way and 2) it most of the time should have led to a segmentation fault due to accessing the `_count` array with negative indices (this is the way I encountered the issue). Nevertheless, an important bug.
@thesamovar

This comment has been minimized.

Show comment
Hide comment
@thesamovar

thesamovar Apr 21, 2015

Member

Code looks good to me so happy for you to merge it as soon as the CIs report back.

Member

thesamovar commented Apr 21, 2015

Code looks good to me so happy for you to merge it as soon as the CIs report back.

@mstimberg

This comment has been minimized.

Show comment
Hide comment
@mstimberg

mstimberg Apr 21, 2015

Member

I'm going to merge this now. One of the travis test suites stalled for some reason, but since this is a single commit on top of current master, the two tests suites ran on the identical code and are therefore redundant. AppVeyor failed because of the standalone filename issue that we discussed, it will be fixed in a separate pull request (it also timed out, though...).

Member

mstimberg commented Apr 21, 2015

I'm going to merge this now. One of the travis test suites stalled for some reason, but since this is a single commit on top of current master, the two tests suites ran on the identical code and are therefore redundant. AppVeyor failed because of the standalone filename issue that we discussed, it will be fixed in a separate pull request (it also timed out, though...).

mstimberg added a commit that referenced this pull request Apr 21, 2015

Merge pull request #454 from brian-team/spikemonitor_subgroup_fix
Fix SpikeMonitor for subgroups (weave, cython, cpp_standalone)

@mstimberg mstimberg merged commit 1307970 into master Apr 21, 2015

1 of 3 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mstimberg mstimberg removed the in progress label Apr 21, 2015

@mstimberg mstimberg deleted the spikemonitor_subgroup_fix branch Apr 21, 2015

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 21, 2015

Coverage Status

Changes Unknown when pulling c99339f on spikemonitor_subgroup_fix into * on master*.

coveralls commented Apr 21, 2015

Coverage Status

Changes Unknown when pulling c99339f on spikemonitor_subgroup_fix into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment