New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen file warnings #892

Merged
merged 3 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@zifeo
Contributor

zifeo commented Oct 23, 2017

Only codegen open have been fixed. Shall I look for other cases? A quick lookup shows more.

Close #851

@mstimberg

This comment has been minimized.

Show comment
Hide comment
@mstimberg

mstimberg Oct 24, 2017

Member

Many thanks for the fix. Fixing the other instances of open(...).read() in the code would be much appreciated!

Member

mstimberg commented Oct 24, 2017

Many thanks for the fix. Fixing the other instances of open(...).read() in the code would be much appreciated!

@mstimberg

This comment has been minimized.

Show comment
Hide comment
@mstimberg

mstimberg Oct 24, 2017

Member

Many thanks again, the changes are all looking good to me. I'll merge as soon as the test suites on the CI servers ran through. 👍

Member

mstimberg commented Oct 24, 2017

Many thanks again, the changes are all looking good to me. I'll merge as soon as the test suites on the CI servers ran through. 👍

@mstimberg mstimberg merged commit 7d5d38c into brian-team:master Oct 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zifeo zifeo deleted the zifeo:fix-851 branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment