The timezone parser in text parser modules missed the : that appears in timezone. As a result it failed to parse the minutes component of the timezone.
Timezone with timezone failed to parse minutes
Could you whip up a regression test for this? Somewhere around here would be good:
The test 'timestamptz with minutes in timezone' is already present. Should the value of property actual be '2010-10-31 14:54:13.74-05:30' instead of '2010-10-31 14:54:13.74-0530' in this test?
The test is passing for me before I merge this pull request so it's either not testing the right thing, or the test is incorrect.
I am certain about following, pg returns timezone in hh:mm format.
test=> create table test(ts timestamptz default current_timestamp);
test=> insert into test(ts) values(default) returning *;
INSERT 0 1
Timezone input in postgres is more lenient as mentioned in the docs: http://www.postgresql.org/docs/9.2/static/datatype-datetime.html#DATATYPE-DATETIME-INPUT. I did not find any reference to the timezone output format.
http://www.w3.org/TR/NOTE-datetime document however is clear about the formats. It specifies TZD = time zone designator (Z or +hh:mm or -hh:mm).
Parse minutes in timezone description
Minutes in timezones are separated with a colon from the hour.
This closes #309
@ajitk I appreciate your help with this one. Sorry it took so long. I was confused on the failing tests, but I got it sorted out now.
@brianc Thanks for the great work. You rock!
😄 open source rocks! 🎸 💃 🎉